Skip to content

Commit a11bd0c

Browse files
jsorefCommit Queue
authored and
Commit Queue
committed
Spelling runtime vm heap
Closes #50785 TEST=ci GitOrigin-RevId: a09e4d5 Change-Id: I0896a003fab240f8edf828955cd827f63dcd4a31 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/276683 Reviewed-by: Slava Egorov <[email protected]> Commit-Queue: Slava Egorov <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
1 parent 23c0ff5 commit a11bd0c

File tree

9 files changed

+11
-11
lines changed

9 files changed

+11
-11
lines changed

runtime/vm/heap/heap.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ void Heap::NotifyIdle(int64_t deadline) {
398398
if (old_space_.ShouldPerformIdleMarkCompact(deadline)) {
399399
// We prefer mark-compact over other old space GCs if we have enough time,
400400
// since it removes old space fragmentation and frees up most memory.
401-
// Blocks for O(heap), roughtly twice as costly as mark-sweep.
401+
// Blocks for O(heap), roughly twice as costly as mark-sweep.
402402
CollectOldSpaceGarbage(thread, GCType::kMarkCompact, GCReason::kIdle);
403403
} else if (old_space_.ReachedHardThreshold()) {
404404
// Even though the following GC may exceed our idle deadline, we need to
@@ -977,7 +977,7 @@ void Heap::ForwardWeakTables(ObjectPointerVisitor* visitor) {
977977
GetWeakTable(Heap::kOld, selector)->Forward(visitor);
978978
}
979979

980-
// Isolates might have forwarding tables (used for during snapshoting in
980+
// Isolates might have forwarding tables (used for during snapshotting in
981981
// isolate communication).
982982
isolate_group()->ForEachIsolate(
983983
[&](Isolate* isolate) {

runtime/vm/heap/marker.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ class MarkingVisitorBase : public ObjectPointerVisitor {
256256
// failing to acquire the mark bit here doesn't reliably indicate the
257257
// object was already encountered through the deferred marking stack. Our
258258
// processing here is idempotent, so repeated visits only hurt performance
259-
// but not correctness. Duplicatation is expected to be low.
259+
// but not correctness. Duplication is expected to be low.
260260
// By the absence of a special case, we are treating WeakProperties as
261261
// strong references here. This guarantees a WeakProperty will only be
262262
// added to the delayed_weak_properties_ list of the worker that
@@ -880,7 +880,7 @@ void GCMarker::StartConcurrentMark(PageSpace* page_space) {
880880
{
881881
// Bulk increase task count before starting any task, instead of
882882
// incrementing as each task is started, to prevent a task which
883-
// races ahead from falsly beleiving it was the last task to complete.
883+
// races ahead from falsely believing it was the last task to complete.
884884
MonitorLocker ml(page_space->tasks_lock());
885885
ASSERT(page_space->phase() == PageSpace::kDone);
886886
page_space->set_phase(PageSpace::kMarking);

runtime/vm/heap/marker.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class Thread;
2525

2626
// The class GCMarker is used to mark reachable old generation objects as part
2727
// of the mark-sweep collection. The marking bit used is defined in RawObject.
28-
// Instances have a lifetime that spans from the beginining of concurrent
28+
// Instances have a lifetime that spans from the beginning of concurrent
2929
// marking (or stop-the-world marking) until marking is complete. In particular,
3030
// an instance may be created and destroyed on different threads if the isolate
3131
// is exited during concurrent marking.

runtime/vm/heap/page.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
namespace dart {
2323

2424
// This cache needs to be at least as big as FLAG_new_gen_semi_max_size or
25-
// munmap will noticably impact performance.
25+
// munmap will noticeably impact performance.
2626
static constexpr intptr_t kPageCacheCapacity = 8 * kWordSize;
2727
static Mutex* page_cache_mutex = nullptr;
2828
static VirtualMemory* page_cache[kPageCacheCapacity] = {nullptr};

runtime/vm/heap/page.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class Thread;
2222

2323
// Pages are allocated with kPageSize alignment so that the Page of any object
2424
// can be computed by masking the object with kPageMask. This does not apply to
25-
// image pages, whose address is choosen by the system loader rather than the
25+
// image pages, whose address is chosen by the system loader rather than the
2626
// Dart VM.
2727
static constexpr intptr_t kPageSize = 512 * KB;
2828
static constexpr intptr_t kPageSizeInWords = kPageSize / kWordSize;

runtime/vm/heap/sampler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class HeapProfileSampler {
4747
// Returns number of bytes that should be be attributed to the sample.
4848
// If returned size is 0, the allocation should not be sampled.
4949
//
50-
// Due to how the poission sampling works, some samples should be accounted
50+
// Due to how the poisson sampling works, some samples should be accounted
5151
// multiple times if they cover allocations larger than the average sampling
5252
// rate.
5353
void SampleSize(intptr_t allocation_size);

runtime/vm/heap/scavenger.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ class ScavengerVisitorBase : public ObjectPointerVisitor {
157157
// update is needed. If the underlying typed data is internal, the pointer
158158
// must be updated if the typed data was copied or promoted. We cannot
159159
// safely dereference the underlying typed data to make this distinction.
160-
// It may have been forwarded by a different scavanger worker, so the access
160+
// It may have been forwarded by a different scavenger worker, so the access
161161
// could have a data race. Rather than checking the CID of the underlying
162162
// typed data, which requires dereferencing the copied/promoted header, we
163163
// compare the view's internal pointer to what it should be if the

runtime/vm/heap/scavenger.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class ScavengeStats {
8686

8787
// Of all data before scavenge, what fraction was found to be garbage?
8888
// If this scavenge included growth, assume the extra capacity would become
89-
// garbage to give the scavenger a chance to stablize at the new capacity.
89+
// garbage to give the scavenger a chance to stabilize at the new capacity.
9090
double ExpectedGarbageFraction() const {
9191
double work =
9292
after_.used_in_words + promoted_in_words_ + abandoned_in_words_;

runtime/vm/heap/sweeper.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ bool GCSweeper::SweepPage(Page* page, FreeList* freelist, bool locked) {
3030
ObjectPtr raw_obj = UntaggedObject::FromAddr(current);
3131
ASSERT(Page::Of(raw_obj) == page);
3232
// These acquire operations balance release operations in array
33-
// truncaton, ensuring the writes creating the filler object are ordered
33+
// truncation, ensuring the writes creating the filler object are ordered
3434
// before the writes inserting the filler object into the freelist.
3535
uword tags = raw_obj->untag()->tags_.load(std::memory_order_acquire);
3636
intptr_t obj_size = raw_obj->untag()->HeapSize(tags);

0 commit comments

Comments
 (0)