Skip to content

Commit a0ebfb9

Browse files
nshahanCommit Queue
authored and
Commit Queue
committed
[ddc] Add canary benchmark configs to test
This should signal what is needed to add DDC canary mode golem configs. Change-Id: Id1fe8ed016641bda4bfa9e5fabacc78b26a35503 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315560 Commit-Queue: Nicholas Shahan <[email protected]> Reviewed-by: Jonas Termansen <[email protected]>
1 parent f167e03 commit a0ebfb9

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

tools/bots/test_matrix.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3168,6 +3168,7 @@
31683168
"dart2js_platform_unsound.dill",
31693169
"kernel-service.dart.snapshot",
31703170
"ddc_stable_test",
3171+
"ddc_canary_test",
31713172
"dart2wasm_benchmark"
31723173
]
31733174
},

tools/bots/try_benchmarks.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ EOF
186186
rm -rf tmp
187187
elif [ "$command" = linux-x64-build ]; then
188188
# NOTE: These are duplicated in tools/bots/test_matrix.json, keep in sync.
189-
./tools/build.py --mode=release --arch=x64 create_sdk runtime gen_snapshot dart_precompiled_runtime dart2js_platform.dill dart2js_platform_unsound.dill kernel-service.dart.snapshot ddc_stable_test dart2wasm_benchmark
189+
./tools/build.py --mode=release --arch=x64 create_sdk runtime gen_snapshot dart_precompiled_runtime dart2js_platform.dill dart2js_platform_unsound.dill kernel-service.dart.snapshot ddc_stable_test ddc_canary_test dart2wasm_benchmark
190190
elif [ "$command" = linux-x64-archive ]; then
191191
export GZIP=-1
192192
strip -w \
@@ -335,6 +335,10 @@ EOF
335335
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --no-sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
336336
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --sound-null-safety hello.dart
337337
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
338+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary --no-sound-null-safety hello.dart
339+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary --no-sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
340+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary --sound-null-safety hello.dart
341+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --canary --sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
338342
out/ReleaseX64/dart-sdk/bin/dart pkg/analysis_server/benchmark/benchmarks.dart run --quick --repeat 1 analysis-server-cold
339343
echo '[{"name":"foo","edits":[["pkg/compiler/lib/src/dart2js.dart","2016","2017"],["pkg/compiler/lib/src/options.dart","2016","2017"]]}]' > appjit_train_edits.json
340344
out/ReleaseX64/dart --background-compilation=false --snapshot-kind=app-jit --snapshot=pkg/front_end/tool/incremental_perf.dart.appjit pkg/front_end/tool/incremental_perf.dart --target=vm --sdk-summary=out/ReleaseX64/vm_platform_strong.dill --sdk-library-specification=sdk/lib/libraries.json pkg/compiler/lib/src/dart2js.dart appjit_train_edits.json

0 commit comments

Comments
 (0)