Skip to content

Commit 9efc804

Browse files
committed
Remove workaround
Upstream bug is fixed now. [email protected] Review URL: https://codereview.chromium.org/1096353002
1 parent b01750f commit 9efc804

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// Messages from compiling sunflower.html
2-
info: line 21, column 29 of test/codegen/sunflower/sunflower.dart: [AssignmentCast] querySelector("#slider") (Element) will need runtime check to cast to type InputElement
2+
info: line 20, column 29 of test/codegen/sunflower/sunflower.dart: [AssignmentCast] querySelector("#slider") (Element) will need runtime check to cast to type InputElement
33
final InputElement slider = querySelector("#slider");
44
^^^^^^^^^^^^^^^^^^^^^^^^
5-
info: line 26, column 5 of test/codegen/sunflower/sunflower.dart: [AssignmentCast] (querySelector("#canvas") as CanvasElement).getContext('2d') (RenderingContext) will need runtime check to cast to type CanvasRenderingContext2D
5+
info: line 25, column 5 of test/codegen/sunflower/sunflower.dart: [AssignmentCast] (querySelector("#canvas") as CanvasElement).getContext('2d') (RenderingContext) will need runtime check to cast to type CanvasRenderingContext2D
66
(querySelector("#canvas") as CanvasElement).getContext('2d');
77
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8-
info: line 29, column 37 of test/codegen/sunflower/sunflower.dart: [InferredTypeClosure] (e) => draw() has inferred type (Event) → void
8+
info: line 28, column 37 of test/codegen/sunflower/sunflower.dart: [InferredTypeClosure] (e) => draw() has inferred type (Event) → void
99
slider.addEventListener('change', (e) => draw());
1010
^^^^^^^^^^^^^

pkg/dev_compiler/test/codegen/sunflower/sunflower.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,8 @@ const SEED_RADIUS = 2;
1212
const SCALE_FACTOR = 4;
1313
const TAU = PI * 2;
1414
const MAX_D = 300;
15-
// TODO(sigmund): remove `num` here, this is to workaround dartbug.com/22937
16-
const num centerX = MAX_D / 2;
17-
const num centerY = centerX;
15+
const centerX = MAX_D / 2;
16+
const centerY = centerX;
1817

1918
Element querySelector(String selector) => document.querySelector(selector);
2019

0 commit comments

Comments
 (0)