fixes #147, add this and super to isStateless

[email protected]

Review URL: https://codereview.chromium.org/1117373002

Author: John Messerly

pkg/dev_compiler/lib/runtime/dart/collection.js

@@ -1626,17 +1626,17 @@ var collection;
       [core.$add](element) {
         dart.as(element, E);
         this[core.$set]((() => {
-          let o = this, x = o[core.$length];
-          o[core.$length] = dart.notNull(x) + 1;
+          let x = this[core.$length];
+          this[core.$length] = dart.notNull(x) + 1;
           return x;
         }).bind(this)(), element);
       }
       [core.$addAll](iterable) {
         dart.as(iterable, core.Iterable$(E));
         for (let element of iterable) {
           this[core.$set]((() => {
-            let o = this, x = o[core.$length];
-            o[core.$length] = dart.notNull(x) + 1;
+            let x = this[core.$length];
+            this[core.$length] = dart.notNull(x) + 1;
             return x;
           }).bind(this)(), element);
         }
@@ -1645,8 +1645,7 @@ var collection;
         for (let i = 0; dart.notNull(i) < dart.notNull(this[core.$length]); i = dart.notNull(i) + 1) {
           if (dart.equals(this[core.$get](i), element)) {
             this[core.$setRange](i, dart.notNull(this[core.$length]) - 1, this, dart.notNull(i) + 1);
-            let o = this;
-            o[core.$length] = dart.notNull(o[core.$length]) - 1;
+            this[core.$length] = dart.notNull(this[core.$length]) - 1;
             return true;
           }
         }
@@ -1739,8 +1738,7 @@ var collection;
         core.RangeError.checkValidRange(start, end, this[core.$length]);
         let length = dart.notNull(end) - dart.notNull(start);
         this[core.$setRange](start, dart.notNull(this[core.$length]) - dart.notNull(length), this, end);
-        let o = this;
-        o[core.$length] = dart.notNull(o[core.$length]) - dart.notNull(length);
+        this[core.$length] = dart.notNull(this[core.$length]) - dart.notNull(length);
       }
       [core.$fillRange](start, end, fill) {
         if (fill === void 0)
@@ -1853,8 +1851,7 @@ var collection;
         }
         if (!(typeof index == 'number'))
           throw new core.ArgumentError(index);
-        let o = this;
-        o[core.$length] = dart.notNull(o[core.$length]) + 1;
+        this[core.$length] = dart.notNull(this[core.$length]) + 1;
         this[core.$setRange](dart.notNull(index) + 1, this[core.$length], this, index);
         this[core.$set](index, element);
       }
@@ -1871,8 +1868,7 @@ var collection;
           iterable = iterable[core.$toList]();
         }
         let insertionLength = iterable[core.$length];
-        let o = this;
-        o[core.$length] = dart.notNull(o[core.$length]) + dart.notNull(insertionLength);
+        this[core.$length] = dart.notNull(this[core.$length]) + dart.notNull(insertionLength);
         this[core.$setRange](dart.notNull(index) + dart.notNull(insertionLength), this[core.$length], this, index);
         this[core.$setAll](index, iterable);
       }

pkg/dev_compiler/lib/runtime/dart/convert.js

@@ -1578,7 +1578,7 @@ var convert;
       return new _Utf8StringSinkAdapter(this, this[_stringSink], allowMalformed);
     }
     asStringSink() {
-      return new ClosableStringSink.fromStringSink(this[_stringSink], dart.bind(this, 'close'));
+      return new ClosableStringSink.fromStringSink(this[_stringSink], this.close.bind(this));
     }
   }
   class _StringCallbackSink extends _StringSinkConversionSink {

pkg/dev_compiler/lib/src/codegen/side_effect_analysis.dart

@@ -28,6 +28,8 @@ import 'package:analyzer/src/generated/element.dart';
 /// correctness of a `true` value. However it may return `false` for things
 /// that are in fact, stateless.
 bool isStateless(Expression node, [AstNode context]) {
+  // `this` and `super` cannot be reassigned.
+  if (node is ThisExpression || node is SuperExpression) return true;
   if (node is SimpleIdentifier) {
     var e = node.staticElement;
     if (e is PropertyAccessorElement) e = e.variable;