fixes #231, mixin application (aka ClassTypeAlias) implicit ctors

[email protected]

Review URL: https://codereview.chromium.org/1193083002.

Author: John Messerly

pkg/dev_compiler/lib/runtime/dart/_internal.js

@@ -1778,12 +1778,20 @@ dart_library.library('dart/_internal', null, /* Imports */[
   });
   let UnmodifiableListMixin = UnmodifiableListMixin$();
   let FixedLengthListBase$ = dart.generic(function(E) {
-    class FixedLengthListBase extends dart.mixin(collection.ListBase$(E), FixedLengthListMixin$(E)) {}
+    class FixedLengthListBase extends dart.mixin(collection.ListBase$(E), FixedLengthListMixin$(E)) {
+      FixedLengthListBase() {
+        super.ListBase(...arguments);
+      }
+    }
     return FixedLengthListBase;
   });
   let FixedLengthListBase = FixedLengthListBase$();
   let UnmodifiableListBase$ = dart.generic(function(E) {
-    class UnmodifiableListBase extends dart.mixin(collection.ListBase$(E), UnmodifiableListMixin$(E)) {}
+    class UnmodifiableListBase extends dart.mixin(collection.ListBase$(E), UnmodifiableListMixin$(E)) {
+      UnmodifiableListBase() {
+        super.ListBase(...arguments);
+      }
+    }
     return UnmodifiableListBase;
   });
   let UnmodifiableListBase = UnmodifiableListBase$();

pkg/dev_compiler/lib/runtime/dart/async.js

@@ -3368,8 +3368,16 @@ dart_library.library('dart/async', null, /* Imports */[
       return null;
     }
   }
-  class _NoCallbackAsyncStreamController extends dart.mixin(_StreamController, _AsyncStreamControllerDispatch, _NoCallbacks) {}
-  class _NoCallbackSyncStreamController extends dart.mixin(_StreamController, _SyncStreamControllerDispatch, _NoCallbacks) {}
+  class _NoCallbackAsyncStreamController extends dart.mixin(_StreamController, _AsyncStreamControllerDispatch, _NoCallbacks) {
+    _NoCallbackAsyncStreamController() {
+      super._StreamController(...arguments);
+    }
+  }
+  class _NoCallbackSyncStreamController extends dart.mixin(_StreamController, _SyncStreamControllerDispatch, _NoCallbacks) {
+    _NoCallbackSyncStreamController() {
+      super._StreamController(...arguments);
+    }
+  }
   let _NotificationHandler = dart.typedef('_NotificationHandler', () => dart.functionType(dart.dynamic, []));
   function _runGuarded(notificationHandler) {
     if (notificationHandler == null)

pkg/dev_compiler/lib/runtime/dart/collection.js

@@ -2321,7 +2321,11 @@ dart_library.library('dart/collection', null, /* Imports */[
   });
   let _UnmodifiableMapMixin = _UnmodifiableMapMixin$();
   let UnmodifiableMapBase$ = dart.generic(function(K, V) {
-    class UnmodifiableMapBase extends dart.mixin(MapBase$(K, V), _UnmodifiableMapMixin$(K, V)) {}
+    class UnmodifiableMapBase extends dart.mixin(MapBase$(K, V), _UnmodifiableMapMixin$(K, V)) {
+      UnmodifiableMapBase() {
+        super.MapBase(...arguments);
+      }
+    }
     return UnmodifiableMapBase;
   });
   let UnmodifiableMapBase = UnmodifiableMapBase$();
@@ -2474,7 +2478,11 @@ dart_library.library('dart/collection', null, /* Imports */[
   });
   let MapView = MapView$();
   let UnmodifiableMapView$ = dart.generic(function(K, V) {
-    class UnmodifiableMapView extends dart.mixin(MapView$(K, V), _UnmodifiableMapMixin$(K, V)) {}
+    class UnmodifiableMapView extends dart.mixin(MapView$(K, V), _UnmodifiableMapMixin$(K, V)) {
+      UnmodifiableMapView() {
+        super.MapView(...arguments);
+      }
+    }
     return UnmodifiableMapView;
   });
   let UnmodifiableMapView = UnmodifiableMapView$();

pkg/dev_compiler/lib/src/codegen/js_codegen.dart

@@ -310,7 +310,6 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
 
   @override
   visitFunctionTypeAlias(FunctionTypeAlias node) {
-    // If we've already emitted this class, skip it.
     var element = node.element;
     var type = element.type;
     var name = element.name;
@@ -329,11 +328,25 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
 
   @override
   JS.Statement visitClassTypeAlias(ClassTypeAlias node) {
-    // If we've already emitted this class, skip it.
     var element = node.element;
 
+    // Forward all generative constructors from the base class.
+    var body = [];
+
+    var supertype = element.supertype;
+    if (!supertype.isObject) {
+      for (var ctor in element.constructors) {
+        var parentCtor = supertype.lookUpConstructor(ctor.name, ctor.library);
+        var fun = js.call('function() { super.#(...#); }', [
+          _constructorName(parentCtor),
+          new JS.Identifier('arguments', allowRename: false)
+        ]);
+        body.add(new JS.Method(_constructorName(ctor), fun));
+      }
+    }
+
     var classDecl = new JS.ClassDeclaration(new JS.ClassExpression(
-        new JS.Identifier(element.name), _classHeritage(element), []));
+        new JS.Identifier(element.name), _classHeritage(element), body));
 
     return _finishClassDef(element.type, classDecl);
   }
@@ -354,7 +367,6 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
 
   @override
   JS.Statement visitClassDeclaration(ClassDeclaration node) {
-    // If we've already emitted this class, skip it.
     var classElem = node.element;
     var type = classElem.type;
     var jsName = findAnnotation(classElem, _isJsNameAnnotation);