[cfe] Avoid concurrent modification in delayed action processing

Closes flutter/flutter#148611

Change-Id: Idb091df6d771f286428809326e65ac6203f09d49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368301
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -1621,8 +1621,11 @@ class BodyBuilder extends StackListenerImpl
   void _unaliasTypeAliasedConstructorInvocations(
       List<TypeAliasedConstructorInvocation>
           typeAliasedConstructorInvocations) {
-    for (TypeAliasedConstructorInvocation invocation
-        in typeAliasedConstructorInvocations) {
+    List<TypeAliasedConstructorInvocation> invocations = [
+      ...typeAliasedConstructorInvocations
+    ];
+    typeAliasedConstructorInvocations.clear();
+    for (TypeAliasedConstructorInvocation invocation in invocations) {
       assert(invocation.hasBeenInferred || isOrphaned(invocation),
           "Node $invocation has not been inferred.");
 

pkg/front_end/test/coverage_suite.dart

@@ -268,7 +268,7 @@ const Map<String, double> _expect = {
   "package:front_end/src/fasta/type_inference/standard_bounds.dart":
       71.42857142857143,
   "package:front_end/src/fasta/type_inference/type_constraint_gatherer.dart":
-      61.328125,
+      60,
   "package:front_end/src/fasta/type_inference/type_demotion.dart":
       77.77777777777779,
   "package:front_end/src/fasta/type_inference/type_inference_engine.dart":

pkg/front_end/testcases/general/flutter_issue148611.dart

@@ -0,0 +1,16 @@
+// Copyright (c) 2024, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// For context see https://github.com/flutter/flutter/issues/148611.
+
+class P<T> {
+  const P(T t);
+}
+
+class A<X> extends P<X> {
+  const A.foo(X x) : super(x);
+  A(super.x) : assert(const F.foo("foo") == const A.foo("foo"));
+}
+
+typedef F<Y> = A<Y>;

pkg/front_end/testcases/general/flutter_issue148611.dart.strong.expect

@@ -0,0 +1,29 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+typedef F<Y extends core::Object? = dynamic> = self::A<Y%>;
+class P<T extends core::Object? = dynamic> extends core::Object /*hasConstConstructor*/  {
+  const constructor •(self::P::T% t) → self::P<self::P::T%>
+    : super core::Object::•()
+    ;
+}
+class A<X extends core::Object? = dynamic> extends self::P<self::A::X%> /*hasConstConstructor*/  {
+  const constructor foo(self::A::X% x) → self::A<self::A::X%>
+    : super self::P::•(x)
+    ;
+  constructor •(self::A::X% x) → self::A<self::A::X%>
+    : assert(#C1 =={core::Object::==}{(core::Object) → core::bool} #C1), super self::P::•(x)
+    ;
+}
+
+constants  {
+  #C1 = self::A<core::String> {}
+}
+
+
+Constructor coverage from constants:
+org-dartlang-testcase:///flutter_issue148611.dart:
+- A.foo (from org-dartlang-testcase:///flutter_issue148611.dart:12:9)
+- P. (from org-dartlang-testcase:///flutter_issue148611.dart:8:9)
+- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart)

pkg/front_end/testcases/general/flutter_issue148611.dart.strong.modular.expect

@@ -0,0 +1,29 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+typedef F<Y extends core::Object? = dynamic> = self::A<Y%>;
+class P<T extends core::Object? = dynamic> extends core::Object /*hasConstConstructor*/  {
+  const constructor •(self::P::T% t) → self::P<self::P::T%>
+    : super core::Object::•()
+    ;
+}
+class A<X extends core::Object? = dynamic> extends self::P<self::A::X%> /*hasConstConstructor*/  {
+  const constructor foo(self::A::X% x) → self::A<self::A::X%>
+    : super self::P::•(x)
+    ;
+  constructor •(self::A::X% x) → self::A<self::A::X%>
+    : assert(#C1 =={core::Object::==}{(core::Object) → core::bool} #C1), super self::P::•(x)
+    ;
+}
+
+constants  {
+  #C1 = self::A<core::String> {}
+}
+
+
+Constructor coverage from constants:
+org-dartlang-testcase:///flutter_issue148611.dart:
+- A.foo (from org-dartlang-testcase:///flutter_issue148611.dart:12:9)
+- P. (from org-dartlang-testcase:///flutter_issue148611.dart:8:9)
+- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart)

pkg/front_end/testcases/general/flutter_issue148611.dart.strong.outline.expect

@@ -0,0 +1,17 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+typedef F<Y extends core::Object? = dynamic> = self::A<Y%>;
+class P<T extends core::Object? = dynamic> extends core::Object /*hasConstConstructor*/  {
+  const constructor •(self::P::T% t) → self::P<self::P::T%>
+    : super core::Object::•()
+    ;
+}
+class A<X extends core::Object? = dynamic> extends self::P<self::A::X%> /*hasConstConstructor*/  {
+  const constructor foo(self::A::X% x) → self::A<self::A::X%>
+    : super self::P::•(x)
+    ;
+  constructor •(self::A::X% x) → self::A<self::A::X%>
+    ;
+}

pkg/front_end/testcases/general/flutter_issue148611.dart.strong.transformed.expect

@@ -0,0 +1,33 @@
+library;
+import self as self;
+import "dart:core" as core;
+
+typedef F<Y extends core::Object? = dynamic> = self::A<Y%>;
+class P<T extends core::Object? = dynamic> extends core::Object /*hasConstConstructor*/  {
+  const constructor •(self::P::T% t) → self::P<self::P::T%>
+    : super core::Object::•()
+    ;
+}
+class A<X extends core::Object? = dynamic> extends self::P<self::A::X%> /*hasConstConstructor*/  {
+  const constructor foo(self::A::X% x) → self::A<self::A::X%>
+    : super self::P::•(x)
+    ;
+  constructor •(self::A::X% x) → self::A<self::A::X%>
+    : assert(#C1 =={core::Object::==}{(core::Object) → core::bool} #C1), super self::P::•(x)
+    ;
+}
+
+constants  {
+  #C1 = self::A<core::String> {}
+}
+
+Extra constant evaluation status:
+Evaluated: EqualsCall @ org-dartlang-testcase:///flutter_issue148611.dart:13:42 -> BoolConstant(true)
+Extra constant evaluation: evaluated: 3, effectively constant: 1
+
+
+Constructor coverage from constants:
+org-dartlang-testcase:///flutter_issue148611.dart:
+- A.foo (from org-dartlang-testcase:///flutter_issue148611.dart:12:9)
+- P. (from org-dartlang-testcase:///flutter_issue148611.dart:8:9)
+- Object. (from org-dartlang-sdk:///sdk/lib/core/object.dart)

pkg/front_end/testcases/general/flutter_issue148611.dart.textual_outline.expect

@@ -0,0 +1,10 @@
+class P<T> {
+  const P(T t);
+}
+
+class A<X> extends P<X> {
+  const A.foo(X x) : super(x);
+  A(super.x) : assert(const F.foo("foo") == const A.foo("foo"));
+}
+
+typedef F<Y> = A<Y>;

pkg/front_end/testcases/general/flutter_issue148611.dart.textual_outline_modelled.expect

@@ -0,0 +1,10 @@
+class A<X> extends P<X> {
+  A(super.x) : assert(const F.foo("foo") == const A.foo("foo"));
+  const A.foo(X x) : super(x);
+}
+
+class P<T> {
+  const P(T t);
+}
+
+typedef F<Y> = A<Y>;