[analyzer] Move 4 more HintCodes to be WarningCodes, NON_CONST*, NULL_CHECK*, STRICT_RAW_TYPE

Bug: #50796
Change-Id: Idcac3ddb582e5b46263fd017c39402b1c11914d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289447
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -1425,25 +1425,6 @@ HintCode.IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION:
 HintCode.IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE:
   status: noFix
   notes: Deprecated
-HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR:
-  status: needsFix
-  notes: |-
-    The fix is to add `const` before the constructor invocation.
-HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW:
-  status: needsFix
-  notes: |-
-    The fix is to replace `new` with `const`.
-HintCode.NULL_CHECK_ALWAYS_FAILS:
-  status: needsFix
-  notes: |-
-    Remove the null check.
-HintCode.STRICT_RAW_TYPE:
-  status: needsFix
-  notes: |-
-    One fix would be to add an explicit `<dynamic>`, but we can also provide
-    more helpful fixes that pretend inference works the way the user may
-    have thought it did. For example in: `List a = <int>[];`, we can add
-    `<int>` after `List`.
 HintCode.UNIGNORABLE_IGNORE:
   status: needsFix
   notes: |-
@@ -2742,6 +2723,14 @@ WarningCode.MUST_BE_IMMUTABLE:
   status: noFix
 WarningCode.MUST_CALL_SUPER:
   status: hasFix
+WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR:
+  status: needsFix
+  notes: |-
+    The fix is to add `const` before the constructor invocation.
+WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW:
+  status: needsFix
+  notes: |-
+    The fix is to replace `new` with `const`.
 WarningCode.NULLABLE_TYPE_IN_CATCH_CLAUSE:
   status: hasFix
 WarningCode.NULL_ARGUMENT_TO_NON_NULL_TYPE:
@@ -2753,6 +2742,10 @@ WarningCode.NULL_AWARE_IN_CONDITION:
   status: noFix
 WarningCode.NULL_AWARE_IN_LOGICAL_OPERATOR:
   status: noFix
+WarningCode.NULL_CHECK_ALWAYS_FAILS:
+  status: needsFix
+  notes: |-
+    Remove the null check.
 WarningCode.OVERRIDE_ON_NON_OVERRIDING_FIELD:
   status: hasFix
 WarningCode.OVERRIDE_ON_NON_OVERRIDING_GETTER:
@@ -2808,6 +2801,13 @@ WarningCode.SDK_VERSION_UI_AS_CODE:
 WarningCode.SDK_VERSION_UI_AS_CODE_IN_CONST_CONTEXT:
   status: noFix
   notes: Deprecated
+WarningCode.STRICT_RAW_TYPE:
+  status: needsFix
+  notes: |-
+    One fix would be to add an explicit `<dynamic>`, but we can also provide
+    more helpful fixes that pretend inference works the way the user may
+    have thought it did. For example in: `List a = <int>[];`, we can add
+    `<int>` after `List`.
 WarningCode.SUBTYPE_OF_SEALED_CLASS:
   status: needsFix
   notes: |-

pkg/analyzer/lib/src/dart/error/hint_codes.g.dart

@@ -164,55 +164,6 @@ class HintCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
-  ///  Generate a hint for non-const instance creation using a constructor
-  ///  annotated with `@literal`.
-  ///
-  ///  Parameters:
-  ///  0: the name of the class defining the annotated constructor
-  static const HintCode NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR = HintCode(
-    'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR',
-    "This instance creation must be 'const', because the {0} constructor is "
-        "marked as '@literal'.",
-    correctionMessage: "Try adding a 'const' keyword.",
-    hasPublishedDocs: true,
-  );
-
-  ///  Generate a hint for non-const instance creation (with the `new` keyword)
-  ///  using a constructor annotated with `@literal`.
-  ///
-  ///  Parameters:
-  ///  0: the name of the class defining the annotated constructor
-  static const HintCode NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW =
-      HintCode(
-    'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR',
-    "This instance creation must be 'const', because the {0} constructor is "
-        "marked as '@literal'.",
-    correctionMessage: "Try replacing the 'new' keyword with 'const'.",
-    hasPublishedDocs: true,
-    uniqueName: 'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW',
-  );
-
-  ///  No parameters.
-  static const HintCode NULL_CHECK_ALWAYS_FAILS = HintCode(
-    'NULL_CHECK_ALWAYS_FAILS',
-    "This null-check will always throw an exception because the expression "
-        "will always evaluate to 'null'.",
-    hasPublishedDocs: true,
-  );
-
-  ///  When "strict-raw-types" is enabled, "raw types" must have type arguments.
-  ///
-  ///  A "raw type" is a type name that does not use inference to fill in missing
-  ///  type arguments; instead, each type argument is instantiated to its bound.
-  ///
-  ///  Parameters:
-  ///  0: the name of the generic type
-  static const HintCode STRICT_RAW_TYPE = HintCode(
-    'STRICT_RAW_TYPE',
-    "The generic type '{0}' should have explicit type arguments but doesn't.",
-    correctionMessage: "Use explicit type arguments for '{0}'.",
-  );
-
   ///  Parameters:
   ///  0: the name of the non-diagnostic being ignored
   static const HintCode UNIGNORABLE_IGNORE = HintCode(

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -811,7 +811,8 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
     _deprecatedVerifier.postfixExpression(node);
     if (node.operator.type == TokenType.BANG &&
         node.operand.typeOrThrow.isDartCoreNull) {
-      _errorReporter.reportErrorForNode(HintCode.NULL_CHECK_ALWAYS_FAILS, node);
+      _errorReporter.reportErrorForNode(
+          WarningCode.NULL_CHECK_ALWAYS_FAILS, node);
     }
     super.visitPostfixExpression(node);
   }
@@ -1344,9 +1345,9 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
       if (constructorName.name != null) {
         fullConstructorName = '$fullConstructorName.${constructorName.name}';
       }
-      HintCode hint = node.keyword?.keyword == Keyword.NEW
-          ? HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW
-          : HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR;
+      var hint = node.keyword?.keyword == Keyword.NEW
+          ? WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW
+          : WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR;
       _errorReporter.reportErrorForNode(hint, node, [fullConstructorName]);
     }
   }

pkg/analyzer/lib/src/error/codes.g.dart

@@ -6453,9 +6453,33 @@ class WarningCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
-  ///  This is the new replacement for [HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR].
-  static const HintCode NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR =
-      HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR;
+  ///  Generate a hint for non-const instance creation using a constructor
+  ///  annotated with `@literal`.
+  ///
+  ///  Parameters:
+  ///  0: the name of the class defining the annotated constructor
+  static const WarningCode NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR = WarningCode(
+    'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR',
+    "This instance creation must be 'const', because the {0} constructor is "
+        "marked as '@literal'.",
+    correctionMessage: "Try adding a 'const' keyword.",
+    hasPublishedDocs: true,
+  );
+
+  ///  Generate a hint for non-const instance creation (with the `new` keyword)
+  ///  using a constructor annotated with `@literal`.
+  ///
+  ///  Parameters:
+  ///  0: the name of the class defining the annotated constructor
+  static const WarningCode NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW =
+      WarningCode(
+    'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR',
+    "This instance creation must be 'const', because the {0} constructor is "
+        "marked as '@literal'.",
+    correctionMessage: "Try replacing the 'new' keyword with 'const'.",
+    hasPublishedDocs: true,
+    uniqueName: 'NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW',
+  );
 
   ///  No parameters.
   static const WarningCode NULLABLE_TYPE_IN_CATCH_CLAUSE = WarningCode(
@@ -6503,6 +6527,14 @@ class WarningCode extends AnalyzerErrorCode {
         "an operand of a logical operator.",
   );
 
+  ///  No parameters.
+  static const WarningCode NULL_CHECK_ALWAYS_FAILS = WarningCode(
+    'NULL_CHECK_ALWAYS_FAILS',
+    "This null-check will always throw an exception because the expression "
+        "will always evaluate to 'null'.",
+    hasPublishedDocs: true,
+  );
+
   ///  A field with the override annotation does not override a getter or setter.
   ///
   ///  No parameters.
@@ -6777,6 +6809,19 @@ class WarningCode extends AnalyzerErrorCode {
     hasPublishedDocs: true,
   );
 
+  ///  When "strict-raw-types" is enabled, "raw types" must have type arguments.
+  ///
+  ///  A "raw type" is a type name that does not use inference to fill in missing
+  ///  type arguments; instead, each type argument is instantiated to its bound.
+  ///
+  ///  Parameters:
+  ///  0: the name of the generic type
+  static const WarningCode STRICT_RAW_TYPE = WarningCode(
+    'STRICT_RAW_TYPE',
+    "The generic type '{0}' should have explicit type arguments but doesn't.",
+    correctionMessage: "Use explicit type arguments for '{0}'.",
+  );
+
   ///  Parameters:
   ///  0: the name of the sealed class
   static const WarningCode SUBTYPE_OF_SEALED_CLASS = WarningCode(

pkg/analyzer/lib/src/error/error_code_values.g.dart

@@ -595,10 +595,6 @@ const List<ErrorCode> errorCodeValues = [
   HintCode.DIVISION_OPTIMIZATION,
   HintCode.IMPORT_DEFERRED_LIBRARY_WITH_LOAD_FUNCTION,
   HintCode.IMPORT_OF_LEGACY_LIBRARY_INTO_NULL_SAFE,
-  HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR,
-  HintCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW,
-  HintCode.NULL_CHECK_ALWAYS_FAILS,
-  HintCode.STRICT_RAW_TYPE,
   HintCode.UNIGNORABLE_IGNORE,
   HintCode.UNNECESSARY_CAST,
   HintCode.UNNECESSARY_FINAL,
@@ -965,11 +961,14 @@ const List<ErrorCode> errorCodeValues = [
   WarningCode.MIXIN_ON_SEALED_CLASS,
   WarningCode.MUST_BE_IMMUTABLE,
   WarningCode.MUST_CALL_SUPER,
+  WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR,
+  WarningCode.NON_CONST_CALL_TO_LITERAL_CONSTRUCTOR_USING_NEW,
   WarningCode.NULLABLE_TYPE_IN_CATCH_CLAUSE,
   WarningCode.NULL_ARGUMENT_TO_NON_NULL_TYPE,
   WarningCode.NULL_AWARE_BEFORE_OPERATOR,
   WarningCode.NULL_AWARE_IN_CONDITION,
   WarningCode.NULL_AWARE_IN_LOGICAL_OPERATOR,
+  WarningCode.NULL_CHECK_ALWAYS_FAILS,
   WarningCode.OVERRIDE_ON_NON_OVERRIDING_FIELD,
   WarningCode.OVERRIDE_ON_NON_OVERRIDING_GETTER,
   WarningCode.OVERRIDE_ON_NON_OVERRIDING_METHOD,
@@ -994,6 +993,7 @@ const List<ErrorCode> errorCodeValues = [
   WarningCode.SDK_VERSION_SINCE,
   WarningCode.SDK_VERSION_UI_AS_CODE,
   WarningCode.SDK_VERSION_UI_AS_CODE_IN_CONST_CONTEXT,
+  WarningCode.STRICT_RAW_TYPE,
   WarningCode.SUBTYPE_OF_SEALED_CLASS,
   WarningCode.TEXT_DIRECTION_CODE_POINT_IN_COMMENT,
   WarningCode.TEXT_DIRECTION_CODE_POINT_IN_LITERAL,

pkg/analyzer/lib/src/error/type_arguments_verifier.dart

@@ -308,7 +308,7 @@ class TypeArgumentsVerifier {
         // See https://github.com/dart-lang/language/blob/master/resources/type-system/strict-raw-types.md#conditions-for-a-raw-type-hint
       } else {
         _errorReporter
-            .reportErrorForNode(HintCode.STRICT_RAW_TYPE, node, [type]);
+            .reportErrorForNode(WarningCode.STRICT_RAW_TYPE, node, [type]);
       }
     }
   }