Skip to content

Commit 8ed1ce9

Browse files
srawlinsCommit Queue
authored and
Commit Queue
committed
svg: do not rename inherited ListMixin.length= parameter
The docs are currently broken because the inherited docs contain references to the parameter, `newLength`, but in the overridden setters, there is no such parameter: https://api.dart.dev/stable/3.4.4/dart-svg/NumberList/length.html CoreLibraryReviewExempt: No-op. Change-Id: I27388847109adeef66cdc1ef2e4faedeac5390d9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372522 Commit-Queue: Sam Rawlins <[email protected]> Auto-Submit: Sam Rawlins <[email protected]> Reviewed-by: Srujan Gaddam <[email protected]>
1 parent 42a1d6d commit 8ed1ce9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sdk/lib/svg/dart2js/svg_dart2js.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2065,7 +2065,7 @@ class LengthList extends JavaScriptObject
20652065
// -- start List<Length> mixins.
20662066
// Length is the element type.
20672067

2068-
set length(int value) {
2068+
set length(int newLength) {
20692069
throw new UnsupportedError("Cannot resize immutable List.");
20702070
}
20712071

@@ -2390,7 +2390,7 @@ class NumberList extends JavaScriptObject
23902390
// -- start List<Number> mixins.
23912391
// Number is the element type.
23922392

2393-
set length(int value) {
2393+
set length(int newLength) {
23942394
throw new UnsupportedError("Cannot resize immutable List.");
23952395
}
23962396

@@ -2873,7 +2873,7 @@ class StringList extends JavaScriptObject
28732873
// -- start List<String> mixins.
28742874
// String is the element type.
28752875

2876-
set length(int value) {
2876+
set length(int newLength) {
28772877
throw new UnsupportedError("Cannot resize immutable List.");
28782878
}
28792879

@@ -3862,7 +3862,7 @@ class TransformList extends JavaScriptObject
38623862
// -- start List<Transform> mixins.
38633863
// Transform is the element type.
38643864

3865-
set length(int value) {
3865+
set length(int newLength) {
38663866
throw new UnsupportedError("Cannot resize immutable List.");
38673867
}
38683868

0 commit comments

Comments
 (0)