Skip to content

Commit 886616c

Browse files
committed
Fixes #519
This is the Symbol bug which is breaking package:unittest. [email protected] Review URL: https://codereview.chromium.org/1915533004 .
1 parent cb59a83 commit 886616c

File tree

3 files changed

+4288
-6017
lines changed

3 files changed

+4288
-6017
lines changed

pkg/dev_compiler/lib/src/compiler/code_generator.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3430,11 +3430,11 @@ class CodeGenerator extends GeneralizingAstVisitor
34303430

34313431
@override
34323432
visitSymbolLiteral(SymbolLiteral node) {
3433-
JS.New emitSymbol() {
3433+
JS.Expression emitSymbol() {
34343434
// TODO(vsm): When we canonicalize, we need to treat private symbols
34353435
// correctly.
34363436
var name = js.string(node.components.join('.'), "'");
3437-
return new JS.New(_emitTypeName(types.symbolType), [name]);
3437+
return js.call('#.new(#)', [_emitTypeName(types.symbolType), name]);
34383438
}
34393439
return _emitConst(emitSymbol);
34403440
}

pkg/dev_compiler/test/browser/language_tests.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,6 @@
280280
'switch_label2_test',
281281
'switch_label_test',
282282
'switch_try_catch_test',
283-
'symbol_literal_test_none_multi',
284283
'sync_generator1_test_none_multi',
285284
'throwing_lazy_variable_test',
286285
'top_level_non_prefixed_library_test',

0 commit comments

Comments
 (0)