Skip to content

Commit 7cfab4e

Browse files
dcharkesCommit Queue
authored and
Commit Queue
committed
[infra/ffi] Skip FFI tests on simulator
Some recent infra shuffling [0] caused FFI tests not to be ingored on some simulator architectures. FFI is not supported on simulators, so ignore tests. [0] https://dart-review.googlesource.com/c/sdk/+/286360 Bug: #48365 Change-Id: Id623733e89f4269feabbe1f1212bdb64a43d7540 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292821 Auto-Submit: Daco Harkes <[email protected]> Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Ryan Macnak <[email protected]>
1 parent f537137 commit 7cfab4e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

tests/ffi/ffi.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ vmspecific_regress_37511_callbacks_test: SkipByDesign # Symbols are not exposed
6666
vmspecific_regress_37511_test: SkipByDesign # Symbols are not exposed on purpose and are not linked in Windows Precompiled. dartbug.com/40579
6767
vmspecific_regress_37780_test: SkipByDesign # Symbols are not exposed on purpose and are not linked in Windows Precompiled. dartbug.com/40579
6868

69-
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ]
69+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simarm_x64 || $arch == simriscv32 || $arch == simriscv64 ]
7070
*: Skip # FFI not yet supported on the arm simulator.
7171

7272
[ $builder_tag == asan || $builder_tag == msan || $builder_tag == tsan ]

tests/ffi_2/ffi_2.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ vmspecific_handle_test: SkipByDesign # Symbols are not exposed on purpose and ar
5757
[ $system != android && $system != linux && $system != macos && $system != windows ]
5858
*: Skip # FFI not yet supported on other OSes.
5959

60-
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simriscv32 || $arch == simriscv64 ]
60+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $arch == simarm_x64 || $arch == simriscv32 || $arch == simriscv64 ]
6161
*: Skip # FFI not yet supported on the arm simulator.
6262

6363
[ $builder_tag == asan || $builder_tag == msan || $builder_tag == tsan ]

0 commit comments

Comments
 (0)