Add strong sections to language_2 and corelib_2, and change to run dart2js in

strong mode for those two suites

Bug:
Change-Id: I5e7b07c9497afd9f9f65fd0de609d5587d3bd9f1
Reviewed-on: https://dart-review.googlesource.com/33120
Reviewed-by: Emily Fortuna <[email protected]>
Commit-Queue: Sigmund Cherem <[email protected]>

Author: sigmundch

pkg/compiler/tool/status_files/update_all.sh

@@ -16,6 +16,9 @@ for arg in "$@"; do
     --with-fast-startup|--fast-startup)
       fast_startup=true
       ;;
+    --strong)
+      strong=true
+      ;;
     --with-checked-mode|--checked-mode|--checked)
       checked_mode=true
       ;;
@@ -31,7 +34,11 @@ for arg in "$@"; do
 done
 
 if [ -z "$suites" ]; then
-  suites="dart2js_native dart2js_extra language language_2 corelib corelib_2 html"
+  if [[ "$strong" == true ]]; then
+    suites="language_2 corelib_2"
+  else
+    suites="dart2js_native dart2js_extra language corelib html"
+  fi
 fi
 
 repodir=$(cd $(dirname ${BASH_SOURCE[0]})/../../../../; pwd)
@@ -41,46 +48,37 @@ binaries_dir=out/ReleaseX64
 
 tmp=$(mktemp -d)
 
+function update_suite_with_flags {
+  local name=$1
+  local suite=$2
+  shift 2
+  local args=$@
+  if [[ "$strong" == true ]]; then
+    name="$name-strong"
+    args="--strong $args"
+  fi
+
+  echo "  - $name tests"
+  ./tools/test.py -m release -c dart2js -r $runtime --dart2js-batch \
+      --dart2js-with-kernel $args $suite > $tmp/$suite-$name.txt
+  echo $tmp/$suite-$name.txt
+  $dart $update_script $name $tmp/$suite-$name.txt
+}
+
 function update_suite {
   local suite=$1
   local runtime="d8"
   if [ "$suite" == "html" ]; then
     runtime="drt"
   fi
   echo -e "\nupdate suite: $suite"
-  echo "  - minified tests"
-  ./tools/test.py -m release -c dart2js -r $runtime --dart2js-batch \
-      --use-sdk --minified --dart2js-with-kernel \
-      $suite > $tmp/$suite-minified.txt
-  $dart $update_script minified $tmp/$suite-minified.txt
-
-
-  echo "  - host-checked tests"
-  ./tools/test.py -m release -c dart2js -r $runtime --dart2js-batch \
-    --host-checked \
-    --dart2js-options="--platform-binaries=$binaries_dir" \
-    --dart2js-with-kernel \
-    $suite > $tmp/$suite-host-checked.txt
-  $dart $update_script host-checked $tmp/$suite-host-checked.txt
-
+  update_suite_with_flags minified $suite "--minified --use-sdk"
+  update_suite_with_flags host-checked $suite "--host-checked"
   if [ "$fast_startup" = true ]; then
-    echo "  - fast-startup tests"
-    ./tools/test.py -m release -c dart2js -r $runtime --dart2js-batch \
-      --fast-startup \
-      --dart2js-options="--platform-binaries=$binaries_dir" \
-      --dart2js-with-kernel \
-      $suite > $tmp/$suite-fast-startup.txt
-    $dart $update_script fast-startup $tmp/$suite-fast-startup.txt
+    update_suite_with_flags fast-startup $suite "--fast-startup"
   fi
-
   if [ "$checked_mode" = true ]; then
-    echo "  - checked mode tests"
-    ./tools/test.py -m release -c dart2js -r $runtime --dart2js-batch \
-      --checked \
-      --dart2js-options="--platform-binaries=$binaries_dir" \
-      --dart2js-with-kernel \
-      $suite > $tmp/$suite-checked-mode.txt
-    $dart $update_script checked-mode $tmp/$suite-checked-mode.txt
+    update_suite_with_flags checked-mode $suite "--checked"
   fi
 }
 

pkg/compiler/tool/status_files/update_from_log.dart

@@ -33,10 +33,18 @@ final dart2jsConfigurations = {
   'host-checked':
       r'[ $compiler == dart2js && $dart2js_with_kernel && $host_checked ]',
   'minified': r'[ $compiler == dart2js && $dart2js_with_kernel && $minified ]',
+  'host-checked-strong':
+      r'[ $compiler == dart2js && $dart2js_with_kernel && $host_checked && $strong ]',
+  'minified-strong':
+      r'[ $compiler == dart2js && $dart2js_with_kernel && $minified && $strong ]',
   'fast-startup':
       r'[ $compiler == dart2js && $dart2js_with_kernel && $fast_startup ]',
+  'fast-startup-strong':
+      r'[ $compiler == dart2js && $dart2js_with_kernel && $fast_startup && $strong ]',
   'checked-mode':
       r'[ $compiler == dart2js && $checked && $dart2js_with_kernel ]',
+  'checked-mode-strong':
+      r'[ $compiler == dart2js && $checked && $dart2js_with_kernel && $strong ]',
 };
 
 final dart2jsStatusFiles = {

tests/corelib_2/corelib_2.status

@@ -215,7 +215,7 @@ string_trimlr_test/02: RuntimeError # Uses Unicode 6.2.0 or earlier.
 [ $compiler == dart2js && !$browser ]
 package_resource_test: RuntimeError # Issue 26842
 
-[ $compiler == dart2js && $checked && $dart2js_with_kernel ]
+[ $compiler == dart2js && $checked && $dart2js_with_kernel && $strong ]
 apply3_test: RuntimeError
 error_stack_trace1_test: RuntimeError # Issue 12399
 from_environment_const_type_test/02: MissingCompileTimeError
@@ -250,11 +250,14 @@ symbol_reserved_word_test/10: MissingCompileTimeError
 symbol_test/02: MissingCompileTimeError
 symbol_test/03: MissingCompileTimeError
 
+[ $compiler == dart2js && $checked && $dart2js_with_kernel && !$strong ]
+*: SkipByDesign
+
 [ $compiler == dart2js && $dart2js_with_kernel ]
 int_from_environment_test: Pass # Issue 31762
 int_parse_radix_test/none: Pass # Issue 31762
 
-[ $compiler == dart2js && $dart2js_with_kernel && $fast_startup ]
+[ $compiler == dart2js && $dart2js_with_kernel && $fast_startup && $strong ]
 iterable_return_type_test/01: RuntimeError
 iterable_return_type_test/02: RuntimeError
 iterable_to_list_test/01: RuntimeError
@@ -270,15 +273,21 @@ symbol_test/02: MissingCompileTimeError
 symbol_test/03: MissingCompileTimeError
 uri_base_test: Crash # RangeError (index): Invalid value: Valid value range is empty: 0
 
-[ $compiler == dart2js && $dart2js_with_kernel && $host_checked ]
+[ $compiler == dart2js && $dart2js_with_kernel && $fast_startup && !$strong ]
+*: SkipByDesign
+
+[ $compiler == dart2js && $dart2js_with_kernel && $host_checked && $strong ]
 apply3_test: RuntimeError
+cast_test: RuntimeError
 error_stack_trace1_test: RuntimeError # Issue 12399
 iterable_return_type_test/01: RuntimeError
 iterable_return_type_test/02: RuntimeError
 iterable_to_list_test/01: RuntimeError
 list_test/01: Crash # Unsupported operation: Unsupported type parameter type node T.
 list_test/none: Crash # Unsupported operation: Unsupported type parameter type node T.
 map_test: Crash # type 'DillClassBuilder' is not a subtype of type 'SourceClassBuilder' of 'named' where
+null_nosuchmethod_test/01: RuntimeError
+null_nosuchmethod_test/none: RuntimeError
 symbol_reserved_word_test/03: RuntimeError
 symbol_reserved_word_test/04: MissingCompileTimeError
 symbol_reserved_word_test/05: MissingCompileTimeError
@@ -287,8 +296,12 @@ symbol_reserved_word_test/10: MissingCompileTimeError
 symbol_test/02: MissingCompileTimeError
 symbol_test/03: MissingCompileTimeError
 
-[ $compiler == dart2js && $dart2js_with_kernel && $minified ]
+[ $compiler == dart2js && $dart2js_with_kernel && $host_checked && !$strong ]
+*: SkipByDesign
+
+[ $compiler == dart2js && $dart2js_with_kernel && $minified && $strong ]
 apply3_test: RuntimeError
+cast_test: RuntimeError
 dynamic_nosuchmethod_test: RuntimeError
 error_stack_trace1_test: RuntimeError
 hash_set_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(_CustomHashSet.#x), local(_CustomHashSet.#)) for j:closure_call(_CustomHashSet__CustomHashSet_closure.call).
@@ -301,6 +314,8 @@ iterable_to_set_test: Crash # Assertion failure: Cannot find value Instance of '
 list_test/01: Crash # Unsupported operation: Unsupported type parameter type node T.
 list_test/none: Crash # Unsupported operation: Unsupported type parameter type node T.
 map_test: Crash # tests/map_test.dart:870:7: Internal problem: Unhandled Null in installDefaultConstructor.
+null_nosuchmethod_test/01: RuntimeError
+null_nosuchmethod_test/none: RuntimeError
 splay_tree_from_iterable_test: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(SplayTreeMap.#v), local(SplayTreeMap.#)) for j:closure_call(SplayTreeMap_SplayTreeMap_closure.call).
 splay_tree_test/01: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(SplayTreeSet.#v), local(SplayTreeSet.#)) for j:closure_call(SplayTreeSet_SplayTreeSet_closure.call).
 splay_tree_test/02: Crash # Assertion failure: Cannot find value Instance of 'ThisLocal' in (local(SplayTreeSet.#v), local(SplayTreeSet.#)) for j:closure_call(SplayTreeSet_SplayTreeSet_closure.call).
@@ -315,6 +330,9 @@ symbol_test/02: MissingCompileTimeError
 symbol_test/03: MissingCompileTimeError
 uri_base_test: Crash # RangeError (index): Invalid value: Valid value range is empty: 0
 
+[ $compiler == dart2js && $dart2js_with_kernel && $minified && !$strong ]
+*: SkipByDesign
+
 [ $compiler == dart2js && !$dart2js_with_kernel ]
 iterable_return_type_test/01: RuntimeError # Issue 20085
 iterable_return_type_test/02: RuntimeError # Dart2js does not support Uint64*.