Skip to content

Commit 6b71414

Browse files
alexmarkovcommit-bot@chromium.org
authored andcommitted
[Test status] Update status of several triaged lib_2/mirrors tests
Change-Id: Ie90688ea7a9fd95a939c87b4c619213b74c904c1 Reviewed-on: https://dart-review.googlesource.com/58422 Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Alexander Markov <[email protected]>
1 parent 1f03109 commit 6b71414

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

tests/lib_2/lib_2_kernel.status

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ isolate/isolate_complex_messages_test: Crash # http://dartbug.com/33128
5151

5252
[ $arch == x64 && $compiler == dartk && $mode == debug && $runtime == vm && $strong ]
5353
mirrors/invocation_fuzz_test: Skip # Because it times out, issue 29439.
54-
mirrors/variable_is_const_test/01: Crash
5554

5655
[ $builder_tag == optimization_counter_threshold && $compiler == dartk ]
5756
isolate/unresolved_ports_test: CompileTimeError, Pass, Timeout # Fails to compile on opt counter builder (#31838)
@@ -72,21 +71,13 @@ isolate/browser/package_resolve_browser_hook_test: CompileTimeError
7271
isolate/browser/package_resolve_browser_test: CompileTimeError
7372

7473
[ $compiler == dartk && $mode == debug && $runtime == vm && $strong ]
75-
mirrors/other_declarations_location_test: Crash # assertion error, TypeParameter not having position.
74+
mirrors/other_declarations_location_test: Crash # Issue 33325 (assertion error, TypeParameter not having position).
7675

7776
[ $compiler == dartk && $mode == debug && $hot_reload_rollback ]
7877
isolate/message3_test/constList_identical: Skip # Timeout
7978

8079
[ $compiler == dartk && $mode == debug && $strong ]
81-
mirrors/instance_members_unimplemented_interface_test: Crash
82-
mirrors/library_import_deferred_loading_test: Crash # Deferred loading kernel issue 28335.
83-
mirrors/load_library_test: Crash
84-
85-
# Enabling of dartk for sim{arm,arm64,dbc64} revelaed these test failures, which
86-
# are to be triaged. Isolate tests are skipped on purpose due to the usage of
87-
# batch mode.
88-
[ $compiler == dartk && $mode == debug && $strong && ($arch == simarm || $arch == simarm64 || $arch == simdbc64) ]
89-
mirrors/variable_is_const_test/01: Crash # Please triage.
80+
mirrors/variable_is_const_test/01: Crash # Issue 32326
9081

9182
[ $compiler == dartk && $runtime == vm && $checked && $strong ]
9283
mirrors/redirecting_factory_different_type_test/01: MissingCompileTimeError # Issue 28424
@@ -121,7 +112,6 @@ mirrors/constructor_private_name_test: RuntimeError
121112
mirrors/constructors_test: CompileTimeError # Issue 31402 (Invocation arguments)
122113
mirrors/dart2js_mirrors_test: RuntimeError # 31916
123114
mirrors/deferred_mirrors_metadata_test: RuntimeError, CompileTimeError # Deferred loading kernel issue 28335.
124-
mirrors/deferred_mirrors_test: Crash # 31916
125115
mirrors/deferred_type_test: CompileTimeError, RuntimeError
126116
mirrors/empty_test: Crash, RuntimeError
127117
mirrors/enum_test: RuntimeError # Issue 31402 (Invocation arguments)
@@ -169,7 +159,7 @@ mirrors/mixin_application_test: RuntimeError # Issue 31402 (Invocation arguments
169159
mirrors/mixin_members_test: CompileTimeError # Issue 31402 (Invocation arguments)
170160
mirrors/native_class_test: SkipByDesign # Imports dart:html
171161
mirrors/operator_test: CompileTimeError # Issue 31402 (Invocation arguments)
172-
mirrors/other_declarations_location_test: RuntimeError
162+
mirrors/other_declarations_location_test: RuntimeError # Issue 33325 (no source positions for type parameters).
173163
mirrors/parameter_annotation_mirror_test: RuntimeError
174164
mirrors/parameter_metadata_test: RuntimeError
175165
mirrors/parameter_of_mixin_app_constructor_test: RuntimeError # Issue 31402 (Invocation arguments)
@@ -243,7 +233,6 @@ mirrors/deferred_constraints_constants_test/default_argument2: Pass
243233
mirrors/fake_function_with_call_test: RuntimeError
244234
mirrors/instance_members_easier_test: RuntimeError
245235
mirrors/instance_members_test: RuntimeError
246-
mirrors/instance_members_unimplemented_interface_test: RuntimeError
247236
mirrors/instance_members_with_override_test: RuntimeError
248237
mirrors/invoke_closurization2_test: RuntimeError
249238
mirrors/invoke_throws_test: RuntimeError

tests/lib_2/mirrors/instance_members_unimplemented_interface_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class I {
1313

1414
abstract class C implements I {}
1515

16-
selectKeys(map, predicate) {
16+
selectKeys<K, V>(Map<K, V> map, bool predicate(V)) {
1717
return map.keys.where((key) => predicate(map[key]));
1818
}
1919

0 commit comments

Comments
 (0)