Move diagnostic_describe_all_properties tests

Change-Id: I541f7e9a39b3b0f3de60cf68117e643ba5b661b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/325966
Auto-Submit: Samuel Rawlins <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Phil Quitslund <[email protected]>

Author: srawlins

pkg/linter/test/rule_test_support.dart

@@ -529,6 +529,18 @@ abstract class BuildContext {
   bool get mounted;
 }
 
+mixin Diagnosticable {
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {}
+}
+
+class DiagnosticableTree with Diagnosticable {
+  List<DiagnosticsNode> debugDescribeChildren() => const [];
+}
+
+class DiagnosticPropertiesBuilder {}
+
+class DiagnosticsNode {}
+
 class Key {
   Key(String value);
 }

pkg/linter/test/rules/all.dart

@@ -60,6 +60,8 @@ import 'depend_on_referenced_packages_test.dart'
 import 'deprecated_consistency_test.dart' as deprecated_consistency;
 import 'deprecated_member_use_from_same_package_test.dart'
     as deprecated_member_use_from_same_package;
+import 'diagnostic_describe_all_properties_test.dart'
+    as diagnostic_describe_all_properties;
 import 'directives_ordering_test.dart' as directives_ordering;
 import 'discarded_futures_test.dart' as discarded_futures;
 import 'do_not_use_environment_test.dart' as do_not_use_environment;
@@ -275,6 +277,7 @@ void main() {
   depend_on_referenced_packages.main();
   deprecated_consistency.main();
   deprecated_member_use_from_same_package.main();
+  diagnostic_describe_all_properties.main();
   directives_ordering.main();
   discarded_futures.main();
   do_not_use_environment.main();

pkg/linter/test/rules/diagnostic_describe_all_properties_test.dart

@@ -0,0 +1,145 @@
+// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:test_reflective_loader/test_reflective_loader.dart';
+
+import '../rule_test_support.dart';
+
+main() {
+  defineReflectiveSuite(() {
+    defineReflectiveTests(DiagnosticDescribeAllPropertiesTest);
+  });
+}
+
+@reflectiveTest
+class DiagnosticDescribeAllPropertiesTest extends LintRuleTest {
+  @override
+  bool get addFlutterPackageDep => true;
+
+  @override
+  String get lintRule => 'diagnostic_describe_all_properties';
+
+  test_field() async {
+    await assertDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  bool p = false;
+}
+''', [
+      lint(83, 1),
+    ]);
+  }
+
+  test_field_collectionOfWidgets() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  List<Widget> p = [];
+}
+''');
+  }
+
+  test_field_coveredByDebugField() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  String foo = '';
+  String debugFoo = '';
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    debugFoo;
+  }
+}
+''');
+  }
+
+  test_field_inDebugDescribeChildren() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget extends DiagnosticableTree {
+  String p = '';
+
+  @override
+  List<DiagnosticsNode> debugDescribeChildren() {
+    p;
+    return [];
+  }
+}
+''');
+  }
+
+  test_field_inDebugFillProperties() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  String p = '';
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    p;
+  }
+}
+''');
+  }
+
+  test_field_private() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  // ignore: unused_field
+  String _p = '';
+}
+''');
+  }
+
+  test_field_string() async {
+    await assertDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  String p = '';
+}
+''', [
+      lint(85, 1),
+    ]);
+  }
+
+  test_field_widget() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  Widget? p;
+}
+''');
+  }
+
+  test_getter_string() async {
+    await assertDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  String get p => '';
+}
+''', [
+      lint(89, 1),
+    ]);
+  }
+
+  test_getter_widget() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  Widget? get p => null;
+}
+''');
+  }
+
+  test_staticField_string() async {
+    await assertNoDiagnostics(r'''
+import 'package:flutter/widgets.dart';
+class MyWidget with Diagnosticable {
+  static String p = '';
+}
+''');
+  }
+}