Trigger checks for generated files also on failed builds

Bug: http://b/183199080
Change-Id: If8a9baed10068f70d24a8831a093e4a4bf240303
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192383
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Michal Terepeta <[email protected]>

Author: michalt

pkg/analysis_server/test/integration/server/bazel_changes_test.dart

@@ -132,15 +132,15 @@ void main() { my_fun(); }
     // error again.
     await resetCompleterAndErrors();
     writeFile(generatedFilePath, 'different_fun() {}');
-    writeFile(commandLogPath, 'Build completed successfully');
+    writeFile(commandLogPath, 'Build completed');
 
     await processedNotification.future;
     expect(errors, isNotEmpty);
 
     // Now delete the file completely.
     await resetCompleterAndErrors();
     File(generatedFilePath).deleteSync();
-    writeFile(commandLogPath, 'Build completed successfully');
+    writeFile(commandLogPath, 'Build did NOT complete successfully');
 
     await processedNotification.future;
     expect(errors, isNotEmpty);

pkg/analyzer/lib/src/workspace/bazel_watcher.dart

@@ -435,9 +435,13 @@ class _BazelInvocationWatcher implements PollTrigger {
   /// Determines how often do we check for `command.log` changes.
   static const _pollInterval = Duration(seconds: 1);
 
-  /// To confirm that a build finished, we check for this message in the
+  /// To confirm that a build finished, we check for these messages in the
   /// `command.log`.
-  static const _buildCompletedMsg = 'Build completed successfully';
+  static const _buildCompletedMsgs = [
+    'Build completed successfully',
+    'Build completed',
+    'Build did NOT complete successfully',
+  ];
 
   final _controller = StreamController<WatchEvent>.broadcast();
   final ResourceProvider _provider;
@@ -459,7 +463,7 @@ class _BazelInvocationWatcher implements PollTrigger {
   bool _buildFinished(String contents) {
     // Only look at the last 100 characters.
     var offset = max(0, contents.length - 100);
-    return contents.contains(_buildCompletedMsg, offset);
+    return _buildCompletedMsgs.any((msg) => contents.contains(msg, offset));
   }
 
   Future<String?> _getCommandLogPath() async {