Clear out outdated binary snapshots when installing.

BUG= http://dartbug.com/23113
[email protected]

Review URL: https://codereview.chromium.org//1087053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45147 260f80e4-7a28-3924-810f-c04153c831b5

Author: nex3

sdk/lib/_internal/pub/lib/src/entrypoint.dart

@@ -255,6 +255,20 @@ class Entrypoint {
     if (!sdkMatches) changed = null;
 
     var graph = await loadPackageGraph();
+
+    // Clean out any outdated snapshots.
+    if (dirExists(binDir)) {
+      for (var entry in listDir(binDir)) {
+        if (!dirExists(entry)) continue;
+
+        var package = path.basename(entry);
+        if (!graph.packages.containsKey(package) ||
+            graph.isPackageMutable(package)) {
+          deleteEntry(entry);
+        }
+      }
+    }
+
     var executables = new Map.fromIterable(root.immediateDependencies,
         key: (dep) => dep.name,
         value: (dep) => _executablesForPackage(graph, dep.name, changed));
@@ -319,7 +333,7 @@ class Entrypoint {
       return executables;
     }
 
-    // If any executables doesn't exist, precompile them regardless of what
+    // If any executables don't exist, precompile them regardless of what
     // changed. Since we delete the bin directory before recompiling, we need to
     // recompile all executables.
     var executablesExist = executables.every((executable) =>

sdk/lib/_internal/pub/test/run/runs_from_a_dependency_override_after_dependency_test.dart

@@ -0,0 +1,54 @@
+// Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import '../descriptor.dart' as d;
+import '../test_pub.dart';
+import '../serve/utils.dart';
+
+main() {
+  initConfig();
+  // Regression test for issue 23113
+  integration('runs a named Dart application in a dependency', () {
+    servePackages((builder) {
+      builder.serve('foo', '1.0.0', pubspec: {
+        'name': 'foo',
+        'version': '1.0.0'
+      }, contents: [
+        d.dir("bin", [
+          d.file("bar.dart", "main() => print('foobar');")
+        ])
+      ]);
+    });
+
+    d.dir(appPath, [
+      d.appPubspec({"foo": null})
+    ]).create();
+
+    pubGet();
+
+    var pub = pubRun(args: ["foo:bar"]);
+    pub.stdout.expect("foobar");
+    pub.shouldExit();
+
+    d.dir("foo", [
+      d.libPubspec("foo", "2.0.0"),
+      d.dir("bin", [
+        d.file("bar.dart", "main() => print('different');")
+      ])
+    ]).create();
+
+    d.dir(appPath, [
+      d.pubspec({
+        "name": "myapp",
+        "dependencies": {"foo": {"path": "../foo"}}
+      })
+    ]).create();
+
+    pubGet();
+
+    pub = pubRun(args: ["foo:bar"]);
+    pub.stdout.expect("different");
+    pub.shouldExit();
+  });
+}