Skip to content

Commit 5d816cb

Browse files
mkustermanncommit-bot@chromium.org
authored andcommitted
[vm/concurrency] Add FLAG_enable_isolate_groups, still defaulting to true
Issue #36097 Change-Id: I3ab8f025eca164b450321abb1b7ef6d7052e7d20 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113998 Reviewed-by: Alexander Aprelev <[email protected]> Reviewed-by: Ryan Macnak <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 480e481 commit 5d816cb

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

runtime/lib/isolate.cc

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,11 @@
2828

2929
namespace dart {
3030

31+
DEFINE_FLAG(bool,
32+
enable_isolate_groups,
33+
true,
34+
"Whether to enable support for isolate groups.");
35+
3136
DEFINE_NATIVE_ENTRY(CapabilityImpl_factory, 0, 1) {
3237
ASSERT(
3338
TypeArguments::CheckedHandle(zone, arguments->NativeArgAt(0)).IsNull());
@@ -152,7 +157,8 @@ class SpawnIsolateTask : public ThreadPool::Task {
152157
// Create a new isolate.
153158
char* error = nullptr;
154159
Isolate* isolate = nullptr;
155-
if (group == nullptr || initialize_callback == nullptr) {
160+
if (!FLAG_enable_isolate_groups || group == nullptr ||
161+
initialize_callback == nullptr) {
156162
// Make a copy of the state's isolate flags and hand it to the callback.
157163
Dart_IsolateFlags api_flags = *(state_->isolate_flags());
158164
isolate = reinterpret_cast<Isolate*>((create_group_callback)(

0 commit comments

Comments
 (0)