dart2js CPS: Evaluate the arguments to abstract class constructors.

Kevin Millikin · Kevin Millikin · commit 5c9a55418721 · 2015-12-08T12:53:01.000+01:00
Constructing an abstract class is a runtime error, but that error should be thrown after the arguments are evaluated. BUG= R=asgerf@google.com Review URL: https://codereview.chromium.org/1506143002 .
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -2155,6 +2155,7 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
       InterfaceType type,
       ast.NodeList arguments,
       CallStructure callStructure, _) {
+    for (ast.Node argument in arguments) visit(argument);
     return buildAbstractClassInstantiationError(element.enclosingClass);
   }
 
diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status
@@ -9623,7 +9623,6 @@ WebPlatformTest/webstorage/storage_builtins_t01: RuntimeError # Please triage th
 WebPlatformTest/webstorage/storage_local_setitem_quotaexceedederr_t01: Skip # Times out. Please triage this failure
 
 [ $compiler == dart2js && $cps_ir ]
-Language/Expressions/Instance_Creation/New/evaluation_t12: RuntimeError # Please triage this failure.
 Language/Expressions/Method_Invocation/Super_Invocation/syntax_t01: RuntimeError # Cannot read property 'call' of undefined
 Language/Expressions/Identifier_Reference/evaluation_variable_or_parameter_t03.dart: Crash # (i=0): For-loop variable captured in loop header
 Language/Statements/For/syntax_t07: Crash # unsupported operation on erroneous element

Original file line number	Diff line number	Diff line change
`@@ -2155,6 +2155,7 @@ abstract class IrBuilderVisitor extends ast.Visitor<ir.Primitive>`
`2155`	`2155`	`InterfaceType type,`
`2156`	`2156`	`ast.NodeList arguments,`
`2157`	`2157`	`CallStructure callStructure, _) {`
	`2158`	`+ for (ast.Node argument in arguments) visit(argument);`
`2158`	`2159`	`return buildAbstractClassInstantiationError(element.enclosingClass);`
`2159`	`2160`	`}`
`2160`	`2161`