You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[stable] [deps] Roll jsshell & firefox to newer version
Issue:
Firefox performs more strict validation when enabling the `js-string`
builtin. Namely it requires the wasm array to `fromCharCodeArray` to be
nullable (as per-spec), where D8 is more lenient and allows non-nullable
wasm array just fine.
In principle it shouldn't be nullable as passing a null will make the
function trap at runtime. But the spec says it should be nullable and if
it isn't, Firefox will fail validation.
Soon Chrome will start enforcing this.
Fix:
Import the function with a nullable wasm array type as parameter.
Why Cherry-pick:
Apps compiled with dart2wasm will no longer work with newer Chrome
(once they roll out stricter validation).
Risk: Low
Issue #59899
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/404300
Change-Id: Icde5eccfdc2cf1e4666be6c670105b896b1a19a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/413440
Commit-Queue: Martin Kustermann <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
0 commit comments