Skip to content

Commit 59a5a36

Browse files
mkustermannCommit Queue
authored and
Commit Queue
committed
[dart2wasm] Add missing polyfill for wasm:js-string.test and remove unused (and not polyfilled) wasm:js-string.fromCodePoint
This is a follow up to [0] that started to make use of `wasm:js-string.test`. [0] https://dart-review.googlesource.com/c/sdk/+/429362 Closes #60763 Change-Id: Iac4b6ad1b845a486e4b8583e18d5f0941f55add6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/429943 Commit-Queue: Martin Kustermann <[email protected]> Reviewed-by: Ömer Ağacan <[email protected]>
1 parent 273ae87 commit 59a5a36

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

pkg/dart2wasm/lib/js/runtime_blob.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ const jsStringPolyfill = {
173173
}
174174
return s.length;
175175
},
176+
"test": (s) => typeof s == "string",
176177
};
177178
''';
178179

sdk/lib/_internal/wasm/lib/js_string.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -999,9 +999,6 @@ external WasmI32 _jsStringEqualsImport(WasmExternRef? s1, WasmExternRef? s2);
999999
@pragma("wasm:import", "wasm:js-string.fromCharCode")
10001000
external WasmExternRef _jsStringFromCharCodeImport(WasmI32 c);
10011001

1002-
@pragma("wasm:import", "wasm:js-string.fromCodePoint")
1003-
external WasmExternRef _jsStringFromCodePointImport(WasmI32 c);
1004-
10051002
@pragma("wasm:import", "wasm:js-string.length")
10061003
external WasmI32 _jsStringLengthImport(WasmExternRef? s);
10071004

0 commit comments

Comments
 (0)