Skip to content

Commit 43fa24f

Browse files
natebiggsCommit Queue
authored and
Commit Queue
committed
[dart2js] Use deferred reads for standalone dump info.
Change-Id: I43492255a1d9db67a95a1c3ed347640d5e66bbc3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363542 Commit-Queue: Nate Biggs <[email protected]> Reviewed-by: Mayank Patke <[email protected]>
1 parent c470a83 commit 43fa24f

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

pkg/compiler/lib/src/compiler.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -626,10 +626,7 @@ class Compiler {
626626

627627
bool get shouldStopAfterCodegen => stage.shouldWriteCodegen;
628628

629-
// Only use deferred reads for the linker phase as most deferred entities will
630-
// not be needed. In other phases we use most of this data so it's not worth
631-
// deferring.
632-
bool get useDeferredSourceReads => stage == CompilerStage.jsEmitter;
629+
bool get useDeferredSourceReads => stage.shouldUseDeferredSourceReads;
633630

634631
Future<void> runSequentialPhases() async {
635632
// Load kernel.

pkg/compiler/lib/src/options.dart

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,12 @@ enum CompilerStage {
101101
bool get shouldWriteGlobalInference => this == CompilerStage.globalInference;
102102
bool get shouldWriteCodegen => this == CompilerStage.codegenSharded;
103103

104+
// Only use deferred reads for the linker and dump info phase as most deferred
105+
// entities will not be needed. In other phases we use most of this data so
106+
// it's not worth deferring.
107+
bool get shouldUseDeferredSourceReads =>
108+
this == CompilerStage.jsEmitter || this == CompilerStage.dumpInfo;
109+
104110
String get toFlag => _stageFlag;
105111

106112
static String get validFlagValuesString {

0 commit comments

Comments
 (0)