[cfe] Allow 'Record' in legacy libraries if experiment flag is set

Closes #50511

Change-Id: Ib9a1922cab3ada271beb6958f73342d52d837257
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275701
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>

Author: chloestefantsova

pkg/front_end/lib/src/fasta/builder/class_builder.dart

@@ -29,6 +29,7 @@ import '../problems.dart' show internalProblem, unhandled;
 import '../scope.dart';
 import '../source/source_library_builder.dart';
 import '../type_inference/type_schema.dart' show UnknownType;
+import '../util/helpers.dart';
 import 'builder.dart';
 import 'declaration_builder.dart';
 import 'library_builder.dart';
@@ -374,7 +375,7 @@ abstract class ClassBuilderImpl extends DeclarationBuilderImpl
         libraryBuilder.importUri.scheme == "dart" &&
         libraryBuilder.importUri.path == "core" &&
         library is SourceLibraryBuilder &&
-        !library.libraryFeatures.records.isEnabled) {
+        !isRecordAccessAllowed(library)) {
       library.reportFeatureNotEnabled(
           library.libraryFeatures.records, fileUri, charOffset, name.length);
       return const InvalidType();

pkg/front_end/lib/src/fasta/builder/named_type_builder.dart

@@ -402,7 +402,7 @@ abstract class NamedTypeBuilder extends TypeBuilder {
     DartType aliasedType = _buildAliasedInternal(library, typeUse, hierarchy);
 
     if (library is SourceLibraryBuilder &&
-        !isRecordAccessAllowed(library.libraryFeatures) &&
+        !isRecordAccessAllowed(library) &&
         isDartCoreRecord(aliasedType)) {
       library.reportFeatureNotEnabled(library.libraryFeatures.records,
           fileUri ?? library.fileUri, charOffset!, nameText.length);
@@ -418,7 +418,7 @@ abstract class NamedTypeBuilder extends TypeBuilder {
     assert(hierarchy != null || isExplicit, "Cannot build $this.");
     DartType builtType = _buildAliasedInternal(library, typeUse, hierarchy);
     if (library is SourceLibraryBuilder &&
-        !isRecordAccessAllowed(library.libraryFeatures) &&
+        !isRecordAccessAllowed(library) &&
         isDartCoreRecord(builtType)) {
       library.reportFeatureNotEnabled(library.libraryFeatures.records,
           fileUri ?? library.fileUri, charOffset!, nameText.length);

pkg/front_end/lib/src/fasta/util/helpers.dart

@@ -5,16 +5,19 @@
 import 'package:kernel/ast.dart';
 
 import '../../api_prototype/experimental_flags.dart';
+import '../source/source_library_builder.dart';
 
 abstract class DelayedActionPerformer {
   bool get hasDelayedActions;
   void performDelayedActions({required bool allowFurtherDelays});
 }
 
 /// Returns `true` if access to `Record` from `dart:core` is allowed.
-bool isRecordAccessAllowed(LibraryFeatures libraryFeatures) {
-  return ExperimentalFlag.records.isEnabledByDefault ||
-      libraryFeatures.records.isEnabled;
+bool isRecordAccessAllowed(SourceLibraryBuilder library) {
+  return library
+          .loader.target.context.options.globalFeatures.records.isEnabled ||
+      ExperimentalFlag.records.isEnabledByDefault ||
+      library.libraryFeatures.records.isEnabled;
 }
 
 /// Returns `true` if [type] is `Record` from  `dart:core`.

pkg/front_end/testcases/records/type_record_unsupported.dart

@@ -6,53 +6,53 @@
 
 import './type_record_unsupported_lib.dart';
 
-typedef R = Record; // Error.
+typedef R = Record; // Ok.
 
-typedef AR = A<Record>; // Error.
+typedef AR = A<Record>; // Ok.
 
 typedef AR2 = A<FromSupportedR>; // Ok.
 
 typedef AR3 = A<FromSupportedRR>; // Ok.
 
-typedef AR4 = A<FromSupportedAR>; // Ok: indirect use.
+typedef AR4 = A<FromSupportedAR>; // Ok.
 
 typedef RR = FromSupportedR; // Ok.
 
-Record foo1() => throw ''; // Error.
+Record foo1() => throw ''; // Ok.
 
 dynamic foo2() => new Record(); // Error.
 
 dynamic foo3() => const Record(); // Error.
 
-dynamic foo4() => <Record>[]; // Error.
+dynamic foo4() => <Record>[]; // Ok.
 
-dynamic foo5() => Record; // Error.
+dynamic foo5() => Record; // Ok.
 
-dynamic foo6() => List<Record>; // Error.
+dynamic foo6() => List<Record>; // Ok.
 
-dynamic foo7(Record r) => null; // Error.
+dynamic foo7(Record r) => null; // Ok.
 
-dynamic foo8({required Record r}) => null; // Error.
+dynamic foo8({required Record r}) => null; // Ok.
 
-List<Record> foo9() => throw ''; // Error.
+List<Record> foo9() => throw ''; // Ok.
 
-dynamic foo10(List<Record> l) => null; // Error.
+dynamic foo10(List<Record> l) => null; // Ok.
 
 FromSupportedR foo11() => throw ''; // Ok.
 
-FromSupportedAR foo12() => throw ''; // Ok: indirect use.
+FromSupportedAR foo12() => throw ''; // Ok.
 
 FromSupportedRR foo13() => throw ''; // Ok.
 
 dynamic foo14(FromSupportedR r) => null; // Ok.
 
-dynamic foo15(FromSupportedAR l) => null; // Ok: indirect use.
+dynamic foo15(FromSupportedAR l) => null; // Ok.
 
 dynamic foo16(FromSupportedRR l) => null; // Ok.
 
 dynamic foo17() => FromSupportedR; // Ok.
 
-dynamic foo18() => FromSupportedAR; // Ok: indirect use.
+dynamic foo18() => FromSupportedAR; // Ok.
 
 dynamic foo19() => FromSupportedRR; // Ok.
 
@@ -62,15 +62,15 @@ abstract class A2 implements Record {} // Error.
 
 abstract class A3 with Record {} // Error.
 
-abstract class A4 extends A<Record> {} // Error.
+abstract class A4 extends A<Record> {} // Ok.
 
-abstract class A5 implements A<Record> {} // Error.
+abstract class A5 implements A<Record> {} // Ok.
 
-abstract class A6 with A<Record> {} // Error.
+abstract class A6 with A<Record> {} // Ok.
 
 abstract class A7 extends FromSupportedR {} // Error.
 
-abstract class A8 extends FromSupportedAR {} // Ok: indirect use.
+abstract class A8 extends FromSupportedAR {} // Ok.
 
 abstract class A9 extends FromSupportedRR {} // Error.