Skip to content

Commit 327d425

Browse files
rmacnak-googleCommit Queue
authored and
Commit Queue
committed
[test] Skip chunked_binary_trees tests on slower configurations.
Bug: #52924 Change-Id: Iece24184411f1fdbc63903d893654c74aed3de55 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313289 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent 2767fca commit 327d425

File tree

3 files changed

+16
-0
lines changed

3 files changed

+16
-0
lines changed

runtime/tests/vm/dart/gc/chunked_binary_trees_array_test.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
// VMOptions=--no_eliminate_write_barriers
1010
// VMOptions=--no_inline_alloc
1111

12+
// Stress test for write barrier elimination that leaves many stores with
13+
// eliminated barriers that create the only reference to an object in flight at
14+
// the same time.
15+
1216
buildTopDown(List n, int depth) {
1317
if (depth == 0) return;
1418

runtime/tests/vm/dart/gc/chunked_binary_trees_test.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
// VMOptions=--no_eliminate_write_barriers
1010
// VMOptions=--no_inline_alloc
1111

12+
// Stress test for write barrier elimination that leaves many stores with
13+
// eliminated barriers that create the only reference to an object in flight at
14+
// the same time.
15+
1216
class Node {
1317
Node? left, right;
1418
int depth;

runtime/tests/vm/vm.status

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ dart_2/transferable_throws_oom_test: SkipByDesign # This test tries to allocate
173173
[ $sanitizer == tsan ]
174174
dart/analyze_snapshot_binary_test: SkipSlow
175175
dart/appjit_cha_deopt_test: SkipSlow
176+
dart/gc/chunked_binary_trees_array_test: SkipSlow
177+
dart/gc/chunked_binary_trees_test: SkipSlow
176178
dart/gc/fragmentation*: Skip # Uses too much memory with TSAN overhead and kills bot
177179
dart/gc/out_of_memory*: Skip # Uses too much memory with TSAN overhead and kills bot
178180
dart/gc/scavenger_abort_test: SkipSlow
@@ -199,6 +201,8 @@ dart_2/v8_snapshot_profile_writer_test: SkipSlow
199201
dart_2/weak_canonical_string_table_test: Pass, Slow # This test can take a longer time to complete.
200202

201203
[ $system == android ]
204+
dart/gc/chunked_binary_trees_array_test: SkipSlow
205+
dart/gc/chunked_binary_trees_test: SkipSlow
202206
dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # On android this test does not work due to not being able to identify library uri.
203207
dart/sdk_hash_test: SkipByDesign # The test doesn't know location of cross-platform gen_snapshot
204208
dart_2/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # On android this test does not work due to not being able to identify library uri.
@@ -264,6 +268,8 @@ cc/Profiler_ToggleRecordAllocation: SkipByDesign
264268
cc/Profiler_TrivialRecordAllocation: SkipByDesign
265269
cc/Profiler_TypedArrayAllocation: SkipByDesign
266270
cc/Service_Profile: SkipByDesign
271+
dart/gc/chunked_binary_trees_array_test: SkipSlow
272+
dart/gc/chunked_binary_trees_test: SkipSlow
267273
dart/gc/splay_c_finalizer_test: SkipByDesign # No FFI on simulators
268274
dart/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
269275
dart/isolates/thread_pool_test: SkipByDesign # https://dartbug.com/37299 Test uses dart:ffi which is not supported on simulators.
@@ -510,6 +516,8 @@ dart_2/thread_priority_windows_test: SkipByDesign
510516
[ $hot_reload || $hot_reload_rollback ]
511517
dart/appjit*: SkipByDesign # Cannot reload with URI pointing to app snapshot.
512518
dart/disassemble_determinism_test: SkipSlow # Runs expensive fibonacci(32) computation in 2 subprocesses
519+
dart/gc/chunked_binary_trees_array_test: SkipSlow
520+
dart/gc/chunked_binary_trees_test: SkipSlow
513521
dart/issue_31959_31960_test: SkipSlow
514522
dart/minimal_kernel_test: SkipSlow # gen_kernel is too slow in hot reload testing mode
515523
dart/null_safety_autodetection_in_kernel_compiler_test: SkipSlow # gen_kernel is too slow in hot reload testing mode

0 commit comments

Comments
 (0)