Skip to content

Commit 2fe6c5d

Browse files
stereotype441Commit Queue
authored and
Commit Queue
committed
Reorganize analysis server's "new language feature" list and add descriptive text.
Based on discussions for the analysis server implementation of the wildcards feature (#55681). Bug: #55681 Change-Id: I8a161ead687ffb71cf18fb573323fbb7c36bf0a3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369501 Reviewed-by: Brian Wilkerson <[email protected]> Reviewed-by: Kallen Tu <[email protected]> Reviewed-by: Phil Quitslund <[email protected]> Commit-Queue: Paul Berry <[email protected]>
1 parent 43ba8eb commit 2fe6c5d

File tree

1 file changed

+58
-31
lines changed

1 file changed

+58
-31
lines changed

pkg/analysis_server/doc/process/new_language_feature.md

Lines changed: 58 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -18,41 +18,68 @@ Separate issues should be created for each of the items in the list.
1818
The following is a list of the individual features that need to be considered.
1919
The features are listed in alphabetical order.
2020

21-
- [ ] Call Hierarchy
22-
- [ ] Closing Labels
21+
- [ ] Call Hierarchy (an IDE feature where you can get a call hierarchy if you
22+
click on a method)
23+
- [ ] Closing Labels (an LSP feature allowing the IDE to show lightly grayed out
24+
comments at the end of the last line of a multi-line invocation, to aid
25+
the user in understanding what invocation is closed by a `)`)
2326
- [ ] Code Completion
2427
- [ ] Code Folding
25-
- [ ] Document Symbols
26-
- [ ] Document Colors
27-
- [ ] Flutter Outline
28+
- [ ] Document Colors (an LSP feature whereby a reference to a color in code can
29+
be associated with a colored swatch and a color picker)
2830
- [ ] Hovers
29-
- [ ] Implemented Markers
30-
- [ ] Inlay Hints
31-
- [ ] Navigation - legacy
32-
- [ ] Navigation - LSP Go to Definition
33-
- [ ] Navigation - LSP Go to Type Definition
34-
- [ ] Navigation - Go to Super
35-
- [ ] Occurrences - legacy
36-
- [ ] Occurrences - LSP Document Highlights
31+
- Implemented/override markers (a legacy protocol feature, only available to
32+
IntelliJ and Android Studio)
33+
- [ ] Implemented Markers (allows navigation from a base class method to
34+
methods that override it, or from a base class to classes that
35+
extend/implement it)
36+
- [ ] Override Markers (allows navigation from a method to the base class
37+
method it overrides, or from a class to the class that it
38+
extends/implements)
39+
- [ ] Inlay Hints (an LSP feature allowing extra information to be displayed
40+
using inline hints)
41+
- Navigation
42+
- [ ] Go to Definition (LSP feature)
43+
- [ ] Go to Type Definition (LSP feature)
44+
- [ ] Go to Super (LSP feature)
45+
- [ ] Legacy protocol (for IntelliJ and Android Studio)
46+
- Occurrences
47+
- [ ] Legacy protocol (for IntelliJ and Android Studio)
48+
- [ ] Document Highlights (LSP feature)
3749
- [ ] Organize Imports
38-
- [ ] Outline
39-
- [ ] Overrides Markers
40-
- [ ] Quick Assists
41-
- [ ] Quick Fixes
42-
- [ ] Refactorings - legacy
43-
- [ ] Refactorings - self describing
44-
- [ ] Search - Find References
45-
- [ ] Search - Implementations - LSP
46-
- [ ] Search - Member Declarations
47-
- [ ] Search - Member References
48-
- [ ] Search - Top-level Declarations
49-
- [ ] Selection Range
50+
- Outline
51+
- [ ] Flutter Outline
52+
- [ ] Legacy protocol, a.k.a. Document Symbols (for IntelliJ and Android
53+
Studio)
54+
- [ ] LSP feature
55+
- Refactorings and quick assists/fixes (note that in addition to potentially
56+
creating new refactorings and/or quick assists/fixes, part of the work
57+
required to implement a new language feature includes evaluating each existing
58+
refactoring and quick fix/assist to see whether it needs to be improved or
59+
have test cases added to reflect the new feature).
60+
- [ ] Legacy refactorings (for IntelliJ and Android Studio)
61+
- [ ] LSP rename refactoring (note that LSP has a special protocol for
62+
renames)
63+
- [ ] LSP self-describing refactorings
64+
- [ ] Quick Assists
65+
- [ ] Quick Fixes
66+
- Search
67+
- [ ] Find References
68+
- [ ] Implementations - LSP
69+
- [ ] Member Declarations
70+
- [ ] Member References
71+
- [ ] Top-level Declarations
72+
- [ ] Selection Range (an LSP feature allowing a selection to be expanded to
73+
cover the range of an ancestor AST node)
5074
- Syntax Highlighting
51-
- [ ] Semantic Highlights
52-
- [ ] LSP Semantic Tokens
53-
- [ ] Signature Help
75+
- [ ] Legacy protocol, a.k.a. Semantic Highlights (for IntelliJ and Android
76+
Studio)
77+
- [ ] Semantic Tokens (LSP feature)
78+
- [ ] Signature Help (an LSP feature that tells the parameters and types needed
79+
for an invocation)
5480
- [ ] Snippets
5581
- [ ] Sort Members
56-
- [ ] Type Hierarchy - legacy
57-
- [ ] Type Hierarchy - LSP
58-
- [ ] Workspace Symbols
82+
- Type Hierarchy
83+
- [ ] Legacy protocol (for IntelliJ and Android Studio)
84+
- [ ] LSP feature
85+
- [ ] Workspace Symbols (LSP feature)

0 commit comments

Comments
 (0)