[vm/kernel/aot] Remove type checks from non-dynamically-invoked implicit setters

This applies optimization from d117760 to implicit setters.

(This CL also reformats kernel_binary_flowgraph.cc because some previous CL
was pushed without proper formatting)

Bug: #31798
Change-Id: I6f1590bfd40e36b972b857c49d6ce8435bb25187
Reviewed-on: https://dart-review.googlesource.com/41300
Commit-Queue: Vyacheslav Egorov <[email protected]>
Reviewed-by: Martin Kustermann <[email protected]>

Author: mraleph

pkg/vm/lib/transformations/no_dynamic_invocations_annotator.dart

@@ -24,6 +24,10 @@ class Selector {
 
   Selector(this.action, this.target);
 
+  Selector.invoke(Name target) : this(Action.invoke, target);
+  Selector.get(Name target) : this(Action.get, target);
+  Selector.set(Name target) : this(Action.set, target);
+
   bool operator ==(other) {
     return other is Selector &&
         other.action == this.action &&
@@ -46,7 +50,7 @@ class Selector {
   }
 }
 
-class NoDynamicInvocationsAnnotator extends RecursiveVisitor<Null> {
+class NoDynamicInvocationsAnnotator {
   final Set<Selector> _dynamicSelectors;
   final ProcedureAttributesMetadataRepository _metadata;
 
@@ -56,17 +60,45 @@ class NoDynamicInvocationsAnnotator extends RecursiveVisitor<Null> {
     program.addMetadataRepository(_metadata);
   }
 
-  @override
+  visitProgram(Program program) {
+    for (var library in program.libraries) {
+      for (var klass in library.classes) {
+        visitClass(klass);
+      }
+    }
+  }
+
+  visitClass(Class node) {
+    for (var member in node.members) {
+      if (member is Procedure) {
+        visitProcedure(member);
+      } else if (member is Field) {
+        visitField(member);
+      }
+    }
+  }
+
+  visitField(Field node) {
+    if (node.isStatic || node.name.name == 'call') {
+      return;
+    }
+
+    if (!_dynamicSelectors.contains(new Selector.set(node.name))) {
+      _metadata.mapping[node] =
+          const ProcedureAttributesMetadata.noDynamicInvocations();
+    }
+  }
+
   visitProcedure(Procedure node) {
     if (node.isStatic || node.name.name == 'call') {
       return;
     }
 
     Selector selector;
     if (node.kind == ProcedureKind.Method) {
-      selector = new Selector(Action.invoke, node.name);
+      selector = new Selector.invoke(node.name);
     } else if (node.kind == ProcedureKind.Setter) {
-      selector = new Selector(Action.set, node.name);
+      selector = new Selector.set(node.name);
     } else {
       return;
     }
@@ -92,7 +124,7 @@ class DynamicSelectorsCollector extends RecursiveVisitor<Null> {
     super.visitMethodInvocation(node);
 
     if (node.dispatchCategory == DispatchCategory.dynamicDispatch) {
-      dynamicSelectors.add(new Selector(Action.invoke, node.name));
+      dynamicSelectors.add(new Selector.invoke(node.name));
     }
   }
 
@@ -101,7 +133,7 @@ class DynamicSelectorsCollector extends RecursiveVisitor<Null> {
     super.visitPropertyGet(node);
 
     if (node.dispatchCategory == DispatchCategory.dynamicDispatch) {
-      dynamicSelectors.add(new Selector(Action.get, node.name));
+      dynamicSelectors.add(new Selector.get(node.name));
     }
   }
 
@@ -110,7 +142,7 @@ class DynamicSelectorsCollector extends RecursiveVisitor<Null> {
     super.visitPropertySet(node);
 
     if (node.dispatchCategory == DispatchCategory.dynamicDispatch) {
-      dynamicSelectors.add(new Selector(Action.set, node.name));
+      dynamicSelectors.add(new Selector.set(node.name));
     }
   }
 }

runtime/vm/compiler/frontend/kernel_binary_flowgraph.cc

@@ -1007,8 +1007,8 @@ ScopeBuildingResult* StreamingScopeBuilder::BuildScopes() {
         VisitNode();
         break;
       }
-      bool is_setter = function.IsImplicitSetterFunction();
-      bool is_method = !function.IsStaticFunction();
+      const bool is_setter = function.IsImplicitSetterFunction();
+      const bool is_method = !function.IsStaticFunction();
       intptr_t pos = 0;
       if (is_method) {
         Class& klass = Class::Handle(Z, function.Owner());
@@ -1025,6 +1025,16 @@ ScopeBuildingResult* StreamingScopeBuilder::BuildScopes() {
             Symbols::Value(),
             AbstractType::ZoneHandle(Z, function.ParameterTypeAt(pos)));
         scope_->InsertParameterAt(pos++, result_->setter_value);
+
+        if (is_method && !attrs.has_dynamic_invocations) {
+          FieldHelper field_helper(builder_);
+          field_helper.ReadUntilIncluding(FieldHelper::kFlags);
+
+          if (!field_helper.IsGenericCovariantImpl()) {
+            result_->setter_value->set_type_check_mode(
+                LocalVariable::kTypeCheckedByCaller);
+          }
+        }
       }
       break;
     }
@@ -5842,9 +5852,9 @@ Fragment StreamingFlowGraphBuilder::StaticCall(
     ICData::RebindRule rebind_rule,
     const InferredTypeMetadata* result_type,
     intptr_t type_args_count) {
-  return flow_graph_builder_->StaticCall(
-      position, target, argument_count, argument_names, rebind_rule,
-      result_type, type_args_count);
+  return flow_graph_builder_->StaticCall(position, target, argument_count,
+                                         argument_names, rebind_rule,
+                                         result_type, type_args_count);
 }
 
 Fragment StreamingFlowGraphBuilder::InstanceCall(
@@ -6928,7 +6938,7 @@ Fragment StreamingFlowGraphBuilder::BuildMethodInvocation(TokenPosition* p) {
 Fragment StreamingFlowGraphBuilder::BuildDirectMethodInvocation(
     TokenPosition* p) {
   const intptr_t offset = ReaderOffset() - 1;  // Include the tag.
-  TokenPosition position = ReadPosition();  // read offset.
+  TokenPosition position = ReadPosition();     // read offset.
   if (p != NULL) *p = position;
 
   const InferredTypeMetadata result_type =
@@ -6991,9 +7001,9 @@ Fragment StreamingFlowGraphBuilder::BuildDirectMethodInvocation(
                      &positional_argument_count);  // read arguments.
   ++argument_count;
 
-  return instructions +
-         StaticCall(position, target, argument_count, argument_names,
-                    ICData::kNoRebind, &result_type, type_args_len);
+  return instructions + StaticCall(position, target, argument_count,
+                                   argument_names, ICData::kNoRebind,
+                                   &result_type, type_args_len);
 }
 
 Fragment StreamingFlowGraphBuilder::BuildSuperMethodInvocation(
@@ -7143,7 +7153,7 @@ Fragment StreamingFlowGraphBuilder::BuildSuperMethodInvocation(
 Fragment StreamingFlowGraphBuilder::BuildStaticInvocation(bool is_const,
                                                           TokenPosition* p) {
   const intptr_t offset = ReaderOffset() - 1;  // Include the tag.
-  TokenPosition position = ReadPosition();  // read position.
+  TokenPosition position = ReadPosition();     // read position.
   if (p != NULL) *p = position;
 
   const InferredTypeMetadata result_type =

runtime/vm/compiler/frontend/kernel_binary_flowgraph.h

@@ -174,6 +174,7 @@ class FieldHelper {
     kFinal = 1 << 0,
     kConst = 1 << 1,
     kStatic = 1 << 2,
+    kIsGenericCovariantImpl = 1 << 6,
     kIsGenericCovariantInterface = 1 << 7
   };
 
@@ -197,6 +198,9 @@ class FieldHelper {
   bool IsConst() { return (flags_ & kConst) != 0; }
   bool IsFinal() { return (flags_ & kFinal) != 0; }
   bool IsStatic() { return (flags_ & kStatic) != 0; }
+  bool IsGenericCovariantImpl() {
+    return (flags_ & kIsGenericCovariantImpl) != 0;
+  }
   bool IsGenericCovariantInterface() {
     return (flags_ & kIsGenericCovariantInterface) != 0;
   }