Skip to content

Commit 204556d

Browse files
committed
Version 2.1.0-dev.9.3
Cherry-pick 65951ef to dev Cherry-pick 6004c8a to dev
2 parents 9c07fb6 + 8a15a9b commit 204556d

File tree

5 files changed

+17
-5
lines changed

5 files changed

+17
-5
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
# 2.1.0-dev.9.3
2+
3+
Cherry-pick 65951ef5080bcfa7d8862685e96f75c2c5d17841 to dev
4+
5+
Cherry-pick 6004c8a1876731e65104cf88f46af01bfe8c24c4 to dev
6+
17
## 2.1.0-dev.9.2
28

39
Cherry-pick 2cf0ca381ce33d1e6597c778eb1a915eecdac109 to dev

pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,9 @@ class Emitter extends emitterTask.EmitterBase {
174174

175175
@override
176176
int generatedSize(OutputUnit unit) {
177+
if (_emitter.omittedFragments.any((f) => f.outputUnit == unit)) {
178+
return 0;
179+
}
177180
Fragment key = _emitter.outputBuffers.keys
178181
.firstWhere((Fragment fragment) => fragment.outputUnit == unit);
179182
return _emitter.outputBuffers[key].length;

pkg/dev_compiler/lib/src/compiler/shared_command.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,9 +149,12 @@ class SharedCompilerOptions {
149149
: (outPaths as List<String>)
150150
.firstWhere((_) => true, orElse: () => null);
151151

152+
// TODO(jmesserly): fix the debugger console so it's not passing invalid
153+
// options.
154+
if (outPath == null) return null;
152155
if (moduleRoot != null) {
153-
// TODO(jmesserly): remove this legacy support after a deprecation period.
154-
// (Mainly this is to give time for migrating build rules.)
156+
// TODO(jmesserly): remove this legacy support after a deprecation
157+
// period. (Mainly this is to give time for migrating build rules.)
155158
moduleName =
156159
path.withoutExtension(path.relative(outPath, from: moduleRoot));
157160
} else {

pkg/dev_compiler/web/web_command.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,13 +285,13 @@ class WebCompileCommand extends Command {
285285
}
286286
resources.newFile(fileName, sourceCode);
287287

288-
compilerOptions.moduleName = path.toUri(libraryName).toString();
288+
var name = path.toUri(libraryName).toString();
289+
compilerOptions.moduleName = name;
289290
JSModuleFile module =
290291
compileWithAnalyzer(driver, [fileName], options, compilerOptions);
291292

292293
var moduleCode = '';
293294
if (module.isValid) {
294-
var name = compilerOptions.moduleName;
295295
moduleCode =
296296
module.getCode(ModuleFormat.legacyConcat, name, name + '.map').code;
297297
}

tools/VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ MAJOR 2
2828
MINOR 1
2929
PATCH 0
3030
PRERELEASE 9
31-
PRERELEASE_PATCH 2
31+
PRERELEASE_PATCH 3

0 commit comments

Comments
 (0)