Remove INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES warnings

Fixes #49112

It was decided to remove the "override with equal default value"
restriction both for null safe code, and for pre-null safe code.

CFE had never issued this static warning, and her we remove it from
analyzer.

Change-Id: I1244e4fe46da8bb4bd8c3a77ec8beb95811e30a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262267
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: srawlins

pkg/analysis_server/lib/src/services/correction/error_fix_status.yaml

@@ -28,7 +28,7 @@
 #   - 206 for ParserErrorCodes.
 # -  68 "needsFix"
 # - 287 "hasFix"
-# -  57 "noFix"
+# -  55 "noFix"
 
 AnalysisOptionsErrorCode.INCLUDED_FILE_PARSE_ERROR:
   status: noFix
@@ -2599,14 +2599,6 @@ StaticWarningCode.INVALID_NULL_AWARE_OPERATOR:
   status: hasFix
 StaticWarningCode.INVALID_NULL_AWARE_OPERATOR_AFTER_SHORT_CIRCUIT:
   status: hasFix
-StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED:
-  status: noFix
-  notes: |-
-    This is a pre-null safety code. No need to add a fix.
-StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL:
-  status: noFix
-  notes: |-
-    This is a pre-null safety code. No need to add a fix.
 StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH:
   status: hasFix
 StaticWarningCode.UNNECESSARY_NON_NULL_ASSERTION:

pkg/analyzer/lib/error/error.dart

@@ -953,8 +953,6 @@ const List<ErrorCode> errorCodeValues = [
   StaticWarningCode.DEAD_NULL_AWARE_EXPRESSION,
   StaticWarningCode.INVALID_NULL_AWARE_OPERATOR,
   StaticWarningCode.INVALID_NULL_AWARE_OPERATOR_AFTER_SHORT_CIRCUIT,
-  StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED,
-  StaticWarningCode.INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL,
   StaticWarningCode.MISSING_ENUM_CONSTANT_IN_SWITCH,
   StaticWarningCode.UNNECESSARY_NON_NULL_ASSERTION,
   TodoCode.TODO,

pkg/analyzer/lib/src/error/codes.g.dart

@@ -5213,40 +5213,6 @@ class StaticWarningCode extends AnalyzerErrorCode {
     uniqueName: 'INVALID_NULL_AWARE_OPERATOR_AFTER_SHORT_CIRCUIT',
   );
 
-  ///  7.1 Instance Methods: It is a static warning if an instance method
-  ///  <i>m1</i> overrides an instance member <i>m2</i>, the signature of
-  ///  <i>m2</i> explicitly specifies a default value for a formal parameter
-  ///  <i>p</i> and the signature of <i>m1</i> specifies a different default value
-  ///  for <i>p</i>.
-  ///
-  ///  Parameters:
-  ///  0: the name of the super class
-  ///  1: the name of the super method
-  ///  2: the name of the overriding method
-  static const StaticWarningCode
-      INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED = StaticWarningCode(
-    'INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED',
-    "Parameters can't override default values, this method overrides '{0}.{1}' "
-        "where '{2}' has a different value.",
-    correctionMessage: "Try using the same default value in both methods.",
-  );
-
-  ///  7.1 Instance Methods: It is a static warning if an instance method
-  ///  <i>m1</i> overrides an instance member <i>m2</i>, the signature of
-  ///  <i>m2</i> explicitly specifies a default value for a formal parameter
-  ///  <i>p</i> and the signature of <i>m1</i> specifies a different default value
-  ///  for <i>p</i>.
-  ///  Parameters:
-  ///  0: the name of the super class
-  ///  1: the name of the super method
-  static const StaticWarningCode
-      INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL = StaticWarningCode(
-    'INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL',
-    "Parameters can't override default values, this method overrides '{0}.{1}' "
-        "where this positional parameter has a different value.",
-    correctionMessage: "Try using the same default value in both methods.",
-  );
-
   ///  Parameters:
   ///  0: the name of the constant that is missing
   static const StaticWarningCode MISSING_ENUM_CONSTANT_IN_SWITCH =

pkg/analyzer/lib/src/error/inheritance_override.dart

@@ -6,7 +6,6 @@ import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/syntactic_entity.dart';
 import 'package:analyzer/dart/ast/token.dart';
-import 'package:analyzer/dart/constant/value.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/type.dart';
 import 'package:analyzer/dart/element/type_provider.dart';
@@ -355,17 +354,6 @@ class _ClassVerifier {
         errorReporter: reporter,
         errorNode: node,
       );
-
-      if (!_isNonNullableByDefault &&
-          superMember is MethodElement &&
-          member is MethodElement &&
-          methodParameterNodes != null) {
-        _checkForOptionalParametersDifferentDefaultValues(
-          superMember,
-          member,
-          methodParameterNodes,
-        );
-      }
     }
 
     if (mixinIndex == -1) {
@@ -504,98 +492,6 @@ class _ClassVerifier {
     return true;
   }
 
-  void _checkForOptionalParametersDifferentDefaultValues(
-    MethodElement baseExecutable,
-    MethodElement derivedExecutable,
-    List<FormalParameter> derivedParameterNodes,
-  ) {
-    var derivedIsAbstract = derivedExecutable.isAbstract;
-    var derivedOptionalNodes = <FormalParameter>[];
-    var derivedOptionalElements = <ParameterElementImpl>[];
-    var derivedParameterElements = derivedExecutable.parameters;
-    for (var i = 0; i < derivedParameterElements.length; i++) {
-      var parameterElement =
-          derivedParameterElements[i] as ParameterElementImpl;
-      if (parameterElement.isOptional) {
-        derivedOptionalNodes.add(derivedParameterNodes[i]);
-        derivedOptionalElements.add(parameterElement);
-      }
-    }
-
-    var baseOptionalElements = <ParameterElementImpl>[];
-    var baseParameterElements = baseExecutable.parameters;
-    for (var i = 0; i < baseParameterElements.length; ++i) {
-      var baseParameter = baseParameterElements[i];
-      if (baseParameter.isOptional) {
-        baseOptionalElements
-            .add(baseParameter.declaration as ParameterElementImpl);
-      }
-    }
-
-    // Stop if no optional parameters.
-    if (baseOptionalElements.isEmpty || derivedOptionalElements.isEmpty) {
-      return;
-    }
-
-    if (derivedOptionalElements[0].isNamed) {
-      for (int i = 0; i < derivedOptionalElements.length; i++) {
-        var derivedElement = derivedOptionalElements[i];
-        if (_isNonNullableByDefault &&
-            derivedIsAbstract &&
-            !derivedElement.hasDefaultValue) {
-          continue;
-        }
-        var name = derivedElement.name;
-        for (var j = 0; j < baseOptionalElements.length; j++) {
-          var baseParameter = baseOptionalElements[j];
-          if (name == baseParameter.name && baseParameter.hasDefaultValue) {
-            var baseValue = baseParameter.computeConstantValue();
-            var derivedResult = derivedElement.evaluationResult!;
-            if (!_constantValuesEqual(derivedResult.value, baseValue)) {
-              reporter.reportErrorForNode(
-                StaticWarningCode
-                    .INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED,
-                derivedOptionalNodes[i],
-                [
-                  baseExecutable.enclosingElement.displayName,
-                  baseExecutable.displayName,
-                  name
-                ],
-              );
-            }
-          }
-        }
-      }
-    } else {
-      for (var i = 0;
-          i < derivedOptionalElements.length && i < baseOptionalElements.length;
-          i++) {
-        var derivedElement = derivedOptionalElements[i];
-        if (_isNonNullableByDefault &&
-            derivedIsAbstract &&
-            !derivedElement.hasDefaultValue) {
-          continue;
-        }
-        var baseElement = baseOptionalElements[i];
-        if (baseElement.hasDefaultValue) {
-          var baseValue = baseElement.computeConstantValue();
-          var derivedResult = derivedElement.evaluationResult!;
-          if (!_constantValuesEqual(derivedResult.value, baseValue)) {
-            reporter.reportErrorForNode(
-              StaticWarningCode
-                  .INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL,
-              derivedOptionalNodes[i],
-              [
-                baseExecutable.enclosingElement.displayName,
-                baseExecutable.displayName
-              ],
-            );
-          }
-        }
-      }
-    }
-  }
-
   /// Check that [classElement] is not a superinterface to itself.
   /// The [path] is a list containing the potentially cyclic implements path.
   ///
@@ -1030,12 +926,4 @@ class _ClassVerifier {
       );
     }
   }
-
-  static bool _constantValuesEqual(DartObject? x, DartObject? y) {
-    // If either constant value couldn't be computed due to an error, the
-    // corresponding DartObject will be `null`.  Since an error has already been
-    // reported, there's no need to report another.
-    if (x == null || y == null) return true;
-    return x == y;
-  }
 }

pkg/analyzer/messages.yaml

@@ -22816,32 +22816,6 @@ StaticWarningCode:
       Parameters:
       0: the null-aware operator that is invalid
       1: the non-null-aware operator that can replace the invalid operator
-  INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_NAMED:
-    problemMessage: "Parameters can't override default values, this method overrides '{0}.{1}' where '{2}' has a different value."
-    correctionMessage: Try using the same default value in both methods.
-    comment: |-
-      7.1 Instance Methods: It is a static warning if an instance method
-      <i>m1</i> overrides an instance member <i>m2</i>, the signature of
-      <i>m2</i> explicitly specifies a default value for a formal parameter
-      <i>p</i> and the signature of <i>m1</i> specifies a different default value
-      for <i>p</i>.
-
-      Parameters:
-      0: the name of the super class
-      1: the name of the super method
-      2: the name of the overriding method
-  INVALID_OVERRIDE_DIFFERENT_DEFAULT_VALUES_POSITIONAL:
-    problemMessage: "Parameters can't override default values, this method overrides '{0}.{1}' where this positional parameter has a different value."
-    correctionMessage: Try using the same default value in both methods.
-    comment: |-
-      7.1 Instance Methods: It is a static warning if an instance method
-      <i>m1</i> overrides an instance member <i>m2</i>, the signature of
-      <i>m2</i> explicitly specifies a default value for a formal parameter
-      <i>p</i> and the signature of <i>m1</i> specifies a different default value
-      for <i>p</i>.
-      Parameters:
-      0: the name of the super class
-      1: the name of the super method
   MISSING_ENUM_CONSTANT_IN_SWITCH:
     problemMessage: "Missing case clause for '{0}'."
     correctionMessage: Try adding a case clause for the missing constant, or adding a default clause.