Fix #31107, crash using generic function syntax in field formal params.

Only fails under the new analysis driver. Flipped all
resolver_test_cases to run under the new analysis mode by default since
that's the default case these days.

Aside from that, the change is pretty small/simple/safe: just had to
resolve type declarations in FieldFormalParameters in two places to
handle both named and non-named forms.

Bug: 31107
Change-Id: I45352f921085e32b53bda1ebcf74a0d51b82e67a
Reviewed-on: https://dart-review.googlesource.com/20561
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Mike Fairhurst <[email protected]>

Author: MichaelRFairhurst

pkg/analyzer/lib/src/generated/declaration_resolver.dart

@@ -136,6 +136,9 @@ class DeclarationResolver extends RecursiveAstVisitor<Object> {
       normalParameter.element = element;
       _setGenericFunctionType(normalParameter.type, element.type);
     }
+    if (normalParameter is FieldFormalParameterImpl) {
+      _setGenericFunctionType(normalParameter.type, element.type);
+    }
 
     Expression defaultValue = node.defaultValue;
     if (defaultValue != null) {
@@ -215,6 +218,7 @@ class DeclarationResolver extends RecursiveAstVisitor<Object> {
         super.visitFieldFormalParameter(node);
       });
       _resolveMetadata(node, node.metadata, element);
+      _setGenericFunctionType(node.type, element.type);
       return null;
     } else {
       return super.visitFieldFormalParameter(node);

pkg/analyzer/test/generated/non_error_resolver_test.dart

@@ -2216,6 +2216,32 @@ class C {
     verify([source]);
   }
 
+  test_fieldFormalParameter_genericFunctionTyped() async {
+    Source source = addSource(r'''
+class C {
+  final Object Function(int, double) field;
+
+  C(String Function(num, Object) this.field);
+}
+''');
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
+  test_fieldFormalParameter_genericFunctionTyped_named() async {
+    Source source = addSource(r'''
+class C {
+  final Object Function(int, double) field;
+
+  C({String Function(num, Object) this.field});
+}
+''');
+    await computeAnalysisResult(source);
+    assertNoErrors(source);
+    verify([source]);
+  }
+
   test_fieldInitializedByMultipleInitializers() async {
     Source source = addSource(r'''
 class A {