Skip to content

Commit 0ebff3d

Browse files
committed
Fix 385,388,398 @lrhn
1 parent d4c8362 commit 0ebff3d

File tree

1 file changed

+21
-12
lines changed

1 file changed

+21
-12
lines changed

sdk/lib/_internal/js_runtime/lib/js_helper.dart

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -380,22 +380,31 @@ class Primitives {
380380
}
381381

382382
static bool? parseBool(String source, bool caseSensitive) {
383-
checkNotNullable(source, "source");
383+
checkNotNullable(source, "source");
384+
checkNotNullable(caseSensitive, "caseSensitive");
384385
//The caseSensitive defaults to true.
385-
if (caseSensitive == null || caseSensitive == true)
386-
return source == "true" ? true : source == "false" ? false : null;
387-
//Ignore case-sensitive when caseSensitive is false.
388-
return _compareIgnoreCase(source, "true")? true : _compareIgnoreCase(source, "false")? false : null;
386+
if (caseSensitive == null || caseSensitive == true)
387+
return source == "true"
388+
? true
389+
: source == "false"
390+
? false
391+
: null;
392+
//Ignore case-sensitive when caseSensitive is false.
393+
return _compareIgnoreCase(source, "true")
394+
? true
395+
: _compareIgnoreCase(source, "false")
396+
? false
397+
: null;
389398
}
390399

391400
static bool _compareIgnoreCase(String input, String lowerCaseTarget) {
392-
if (input.length != lowerCaseTarget.length) return false;
393-
for (var i = 0; i < input.length; i++) {
394-
if (input.codeUnitAt(i) | 0x20 != lowerCaseTarget.codeUnitAt(i)) {
395-
return false;
396-
}
397-
}
398-
return true;
401+
if (input.length != lowerCaseTarget.length) return false;
402+
for (var i = 0; i < input.length; i++) {
403+
if (input.codeUnitAt(i) | 0x20 != lowerCaseTarget.codeUnitAt(i)) {
404+
return false;
405+
}
406+
}
407+
return true;
399408
}
400409

401410
/// [: r"$".codeUnitAt(0) :]

0 commit comments

Comments
 (0)