Skip to content

Commit 0c87126

Browse files
rmacnak-googleCommit Queue
authored and
Commit Queue
committed
[vm] Finish removing legacy restart mechanism.
Cf. a4adbff. TEST=ci Change-Id: I9d2517c6cb0b5630990d087812e9a54241f41bb8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280043 Reviewed-by: Alexander Aprelev <[email protected]> Commit-Queue: Ryan Macnak <[email protected]>
1 parent ee32255 commit 0c87126

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

runtime/vm/message_handler.cc

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ const char* MessageHandler::MessageStatusString(MessageStatus status) {
4444
return "OK";
4545
case kError:
4646
return "Error";
47-
case kRestart:
48-
return "Restart";
4947
case kShutdown:
5048
return "Shutdown";
5149
default:
@@ -358,19 +356,17 @@ bool MessageHandler::ShouldPauseOnStart(MessageStatus status) const {
358356
}
359357
// If we are restarting or shutting down, we do not want to honor
360358
// should_pause_on_start or should_pause_on_exit.
361-
return (status != MessageHandler::kRestart &&
362-
status != MessageHandler::kShutdown) &&
363-
should_pause_on_start() && owning_isolate->is_runnable();
359+
return (status != MessageHandler::kShutdown) && should_pause_on_start() &&
360+
owning_isolate->is_runnable();
364361
}
365362

366363
bool MessageHandler::ShouldPauseOnExit(MessageStatus status) const {
367364
Isolate* owning_isolate = isolate();
368365
if (owning_isolate == NULL) {
369366
return false;
370367
}
371-
return (status != MessageHandler::kRestart &&
372-
status != MessageHandler::kShutdown) &&
373-
should_pause_on_exit() && owning_isolate->is_runnable();
368+
return (status != MessageHandler::kShutdown) && should_pause_on_exit() &&
369+
owning_isolate->is_runnable();
374370
}
375371
#endif
376372

runtime/vm/message_handler.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ class MessageHandler {
2525
enum MessageStatus {
2626
kOK, // We successfully handled a message.
2727
kError, // We encountered an error handling a message.
28-
kRestart, // The VM is restarting.
2928
kShutdown, // The VM is shutting down.
3029
};
3130
static const char* MessageStatusString(MessageStatus status);

0 commit comments

Comments
 (0)