[dart2js] Remove references to global growable list checks.

This is dead code, the field 'isFixedArrayCheckedForGrowable' is never read. Also drop code used to set this field.

The check suggested in the TODO in ssa/builder.dart doesn't reduce code size for cm_shell at all so it seems like all arrays that go through there end up getting "marked" anyway.

Change-Id: Ia4bf3eec3757fc7eadb503a7ccc58b8f60f86b6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244482
Reviewed-by: Stephen Adams <[email protected]>
Reviewed-by: Sigmund Cherem <[email protected]>
Commit-Queue: Nate Biggs <[email protected]>

Author: natebiggs

pkg/compiler/lib/src/inferrer/engine.dart

@@ -261,10 +261,6 @@ class InferrerEngine {
 
     info.bailedOut = false;
     info.elementType.inferred = true;
-    if (abstractValueDomain.isSpecializationOf(
-        info.originalType, abstractValueDomain.fixedListType)) {
-      info.checksGrowable = tracer.callsGrowableMethod;
-    }
     tracer.inputs.forEach(info.elementType.addInput);
     // Enqueue the list for later refinement
     _workQueue.add(info);

pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart

@@ -161,13 +161,8 @@ class TypeGraphInferrer implements TypesInferrer {
     });
 
     Map<ir.TreeNode, AbstractValue> allocatedLists = {};
-    Set<ir.TreeNode> checkedForGrowableLists = {};
     inferrer.types.allocatedLists
         .forEach((ir.TreeNode node, ListTypeInformation typeInformation) {
-      ListTypeInformation info = inferrer.types.allocatedLists[node];
-      if (info.checksGrowable) {
-        checkedForGrowableLists.add(node);
-      }
       allocatedLists[node] = typeInformation.type;
     });
 
@@ -177,7 +172,6 @@ class TypeGraphInferrer implements TypesInferrer {
         _inferredDataBuilder.close(closedWorld),
         memberResults,
         parameterResults,
-        checkedForGrowableLists,
         inferrer.returnsListElementTypeSet,
         allocatedLists);
 

pkg/compiler/lib/src/inferrer/type_graph_nodes.dart

@@ -1757,10 +1757,6 @@ class ListTypeInformation extends TypeInformation with TracedTypeInformation {
   /// The length after the container has been traced.
   int inferredLength;
 
-  /// Whether this list goes through a growable check.
-  /// We conservatively assume it does.
-  bool checksGrowable = true;
-
   ListTypeInformation(
       AbstractValueDomain abstractValueDomain,
       MemberTypeInformation context,

pkg/compiler/lib/src/inferrer/types.dart

@@ -146,10 +146,6 @@ abstract class GlobalTypeInferenceResults {
   /// the given [receiver] type.
   AbstractValue resultTypeOfSelector(Selector selector, AbstractValue receiver);
 
-  /// Returns whether a fixed-length constructor call goes through a growable
-  /// check.
-  bool isFixedArrayCheckedForGrowable(ir.TreeNode node);
-
   /// Returns the type of a list new expression [node].  Returns `null` if
   /// [node] does not represent the construction of a new list.
   AbstractValue typeOfNewList(ir.TreeNode node);
@@ -225,7 +221,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
 
   final Map<MemberEntity, GlobalTypeInferenceMemberResult> memberResults;
   final Map<Local, AbstractValue> parameterResults;
-  final Set<ir.TreeNode> checkedForGrowableLists;
   final Set<Selector> returnsListElementTypeSet;
   final Map<ir.TreeNode, AbstractValue> _allocatedLists;
 
@@ -235,7 +230,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
       this.inferredData,
       this.memberResults,
       this.parameterResults,
-      this.checkedForGrowableLists,
       this.returnsListElementTypeSet,
       this._allocatedLists)
       : _deadFieldResult =
@@ -262,7 +256,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
     Map<Local, AbstractValue> parameterResults = source.readLocalMap(() =>
         closedWorld.abstractValueDomain
             .readAbstractValueFromDataSource(source));
-    Set<ir.TreeNode> checkedForGrowableLists = source.readTreeNodes().toSet();
     Set<Selector> returnsListElementTypeSet =
         source.readList(() => Selector.readFromDataSource(source)).toSet();
     Map<ir.TreeNode, AbstractValue> allocatedLists = source.readTreeNodeMap(
@@ -275,7 +268,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
         inferredData,
         memberResults,
         parameterResults,
-        checkedForGrowableLists,
         returnsListElementTypeSet,
         allocatedLists);
   }
@@ -295,7 +287,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
         parameterResults,
         (AbstractValue value) => closedWorld.abstractValueDomain
             .writeAbstractValueToDataSink(sink, value));
-    sink.writeTreeNodes(checkedForGrowableLists);
     sink.writeList(returnsListElementTypeSet,
         (Selector selector) => selector.writeToDataSink(sink));
     sink.writeTreeNodeMap(
@@ -407,14 +398,6 @@ class GlobalTypeInferenceResultsImpl implements GlobalTypeInferenceResults {
     }
   }
 
-  /// Returns whether a fixed-length constructor call goes through a growable
-  /// check.
-  // TODO(sigmund): move into the result of the element containing such
-  // constructor call.
-  @override
-  bool isFixedArrayCheckedForGrowable(ir.Node ctorCall) =>
-      checkedForGrowableLists.contains(ctorCall);
-
   @override
   AbstractValue typeOfNewList(ir.Node node) => _allocatedLists[node];
 
@@ -507,9 +490,6 @@ class TrivialGlobalTypeInferenceResults implements GlobalTypeInferenceResults {
     sink.writeBool(true); // Is trivial.
   }
 
-  @override
-  bool isFixedArrayCheckedForGrowable(ir.Node node) => false;
-
   @override
   AbstractValue resultTypeOfSelector(Selector selector, AbstractValue mask) {
     return closedWorld.abstractValueDomain.dynamicType;

pkg/compiler/lib/src/ssa/builder.dart

@@ -4082,16 +4082,13 @@ class KernelSsaGraphBuilder extends ir.Visitor<void> with ir.VisitorVoidMixin {
             canThrow ? NativeThrowBehavior.MAY : NativeThrowBehavior.NEVER)
       ..sourceInformation = sourceInformation;
     push(foreign);
-    // TODO(redemption): Global type analysis tracing may have determined that
-    // the fixed-length property is never checked. If so, we can avoid marking
-    // the array.
-    {
-      js.Template code = js.js.parseForeignJS(r'#.fixed$length = Array');
-      // We set the instruction as [canThrow] to avoid it being dead code.
-      // We need a finer grained side effect.
-      add(HForeignCode(code, _abstractValueDomain.nullType, [stack.last],
-          throwBehavior: NativeThrowBehavior.MAY));
-    }
+    js.Template fixedLengthMarker =
+        js.js.parseForeignJS(r'#.fixed$length = Array');
+    // We set the instruction as [canThrow] to avoid it being dead code.
+    // We need a finer grained side effect.
+    add(HForeignCode(
+        fixedLengthMarker, _abstractValueDomain.nullType, [stack.last],
+        throwBehavior: NativeThrowBehavior.MAY));
 
     HInstruction newInstance = stack.last;