remove ignoreTypes flag, it doesn't work, see #134

If we wanted to bring this back, we should implement it differently, IMO
Instead simply replace all type annotations with `dynamic`

[email protected]

Review URL: https://codereview.chromium.org/1163393002

Author: John Messerly

pkg/dev_compiler/lib/src/checker/rules.dart

@@ -75,11 +75,11 @@ abstract class TypeRules {
 
   DartType elementType(Element e);
 
-  bool isDynamic(DartType t);
   bool isDynamicTarget(Expression expr);
   bool isDynamicCall(Expression call);
 }
 
+// TODO(jmesserly): this is unused.
 class DartRules extends TypeRules {
   DartRules(TypeProvider provider) : super(provider);
 
@@ -465,16 +465,13 @@ class RestrictedRules extends TypeRules {
     return (e as dynamic).type;
   }
 
-  bool isDynamic(DartType t) => options.ignoreTypes || t.isDynamic;
-
   /// Returns `true` if the target expression is dynamic.
-  bool isDynamicTarget(Expression target) =>
-      options.ignoreTypes || utils.isDynamicTarget(target);
+  // TODO(jmesserly): remove this in favor of utils? Or a static method here?
+  bool isDynamicTarget(Expression target) => utils.isDynamicTarget(target);
 
   /// Returns `true` if the expression is a dynamic function call or method
   /// invocation.
   bool isDynamicCall(Expression call) {
-    if (options.ignoreTypes) return true;
     var t = getTypeAsCaller(call);
     // TODO(leafp): This will currently return true if t is Function
     // This is probably the most correct thing to do for now, since

pkg/dev_compiler/lib/src/codegen/js_codegen.dart

@@ -1879,10 +1879,6 @@ class JSCodegenVisitor extends GeneralizingAstVisitor {
     var leftType = getStaticType(left);
     var rightType = getStaticType(right);
 
-    // TODO(jmesserly): this may not work correctly with options.ignoreTypes,
-    // because that results in unreliable type annotations. See issue #134,
-    // probably the checker/resolver is the right place to implement that, by
-    // replacing staticTypes with `dynamic` as needed, so codegen "just works".
     var code;
     if (op.type.isEqualityOperator) {
       // If we statically know LHS or RHS is null we can generate a clean check.

pkg/dev_compiler/lib/src/options.dart

@@ -80,11 +80,8 @@ class RulesOptions extends TypeOptions {
   /// Whether to inject casts between Dart assignable types.
   final bool relaxedCasts;
 
-  /// Whether to use static types for code generation.
-  final bool ignoreTypes;
-
-  RulesOptions({this.inferDownwards: inferDownwardsDefault,
-      this.relaxedCasts: true, this.ignoreTypes: false});
+  RulesOptions(
+      {this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true});
 }
 
 class JSCodeOptions {
@@ -188,10 +185,6 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
   @override
   final List<String> nonnullableTypes;
 
-  /// Whether to use static types for code generation.
-  @override
-  final bool ignoreTypes;
-
   /// Whether to emit the source map files.
   @override
   final bool emitSourceMaps;
@@ -205,8 +198,8 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
   final Map<String, String> customUrlMappings;
 
   CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
-      this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
-      this.outputDir, this.useColors: true, this.relaxedCasts: true,
+      this.dumpInfoFile, this.forceCompile: false, this.outputDir,
+      this.useColors: true, this.relaxedCasts: true,
       this.useMultiPackage: false, this.packageRoot: 'packages/',
       this.packagePaths: const <String>[], this.resources: const <String>[],
       this.inferDownwards: RulesOptions.inferDownwardsDefault,
@@ -272,7 +265,6 @@ CompilerOptions parseOptions(List<String> argv) {
       dumpInfo: dumpInfo,
       dumpInfoFile: args['dump-info-file'],
       forceCompile: args['force-compile'] || serverMode,
-      ignoreTypes: args['ignore-types'],
       outputDir: outputDir,
       relaxedCasts: args['relaxed-casts'],
       useColors: useColors,
@@ -310,8 +302,6 @@ final ArgParser argParser = new ArgParser()
       abbr: 's', help: 'Typecheck sdk libs', defaultsTo: false)
   ..addFlag('mock-sdk',
       abbr: 'm', help: 'Use a mock Dart SDK', defaultsTo: false)
-  ..addFlag('ignore-types',
-      help: 'Ignore types during codegen', defaultsTo: false)
   ..addFlag('relaxed-casts',
       help: 'Cast between Dart assignable types', defaultsTo: true)
   ..addOption('nonnullable',