Skip to content

Ensure that all ReceivePorts in pub are closed when they're finished #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DartBot opened this issue Jun 5, 2015 · 4 comments
Closed

Ensure that all ReceivePorts in pub are closed when they're finished #699

DartBot opened this issue Jun 5, 2015 · 4 comments
Labels
closed-stale Closed as the issue or PR is assumed stale P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#14724

Isolate ReceivePorts are no longer automatically garbage collected, so we need to be sure we're closing them properly so we don't leak memory.
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

Marked this as blocking #647.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent

Removed Priority-Unassigned label.
Added Priority-Low label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent

Do we have a way to validate this? Do we know if it's still an issue?

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Priority-Low closed-stale Closed as the issue or PR is assumed stale labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3

I think we'd have seen some effects if this were an issue.

Added AssumedStale label.

@DartBot DartBot closed this as completed Jun 5, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@sigurdm sigurdm added P3 A lower priority bug or feature request and removed low priority labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-stale Closed as the issue or PR is assumed stale P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sigurdm @DartBot