Skip to content

upgrade dartdoc to 0.30.0+1 #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Jan 9, 2020 · 4 comments
Closed

upgrade dartdoc to 0.30.0+1 #3232

jcollins-g opened this issue Jan 9, 2020 · 4 comments

Comments

@jcollins-g
Copy link

I recommend updating pub.dev to dartdoc 0.30.0 as soon as possible because of a number of critical bugfixes. Some of them are in the new version of analyzer and you'll get those for free, but others require updating the version of dartdoc.

@isoos
Copy link
Collaborator

isoos commented Jan 9, 2020

Thanks, I'll do the upgrade tomorrow, and we shall deploy it next week.

@jcollins-g jcollins-g changed the title upgrade dartdoc to 0.30.0 upgrade dartdoc to 0.30.0+1 Jan 9, 2020
@jcollins-g
Copy link
Author

A consequence of base href being removed was a small bug, patched in dartdoc 0.30.0+1.

@isoos
Copy link
Collaborator

isoos commented Jan 10, 2020

I've found a small issue with the canonical URL generation: dart-lang/dartdoc#2122, which we should be able to fix on our end, and it also seems that we'll need to adjust some of the HTML customization we are doing.

@isoos
Copy link
Collaborator

isoos commented Jan 10, 2020

dart-lang/dartdoc#2123 seems to be more interesting issue, as it seems to be random in which library the classes end up with, and there is no visual clue where to look for them if I'm looking in the other library. No mention in the changelog why it would happen or how to influence it.

Update: I've realized that this is not that much of an issue, as the library page has cross-links, only the files were missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants