Skip to content

move third party libs to third_party/ #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jonasfj opened this issue Jan 18, 2019 · 2 comments
Closed

move third party libs to third_party/ #1969

jonasfj opened this issue Jan 18, 2019 · 2 comments
Labels
P3 low
Milestone
M11

Comments

@jonasfj
Copy link
Member

jonasfj commented Jan 18, 2019

Sources that aren't under CLA must be included in third_party/ folder.

Example

  • static/highlight/highlight.pack.js
@isoos
Copy link
Collaborator

isoos commented Jan 21, 2019

Shall we handle two sources for /static handler, or shall we copy the files from third_party/ to /static before serving?

@jonasfj
Copy link
Member Author

jonasfj commented Jan 21, 2019

Probably just as easy to have a separate handler for /static/highlight/ that way we don't accidentally move it it back..

But I don't think it's particularly important... any solution is fine with me.

@jonasfj jonasfj added the P3 low label Jan 21, 2019
@isoos isoos mentioned this issue Jan 23, 2019
Merged
@isoos isoos added this to the M11 milestone Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 low
Projects
None yet
Milestone
M11
Development

No branches or pull requests
2 participants
@jonasfj @isoos