Searches includes packages that are marked discontinued

[mit-mit]

For example, https://pub.dartlang.org/packages?q=email%3Amisc%40dartlang.org&page=15

This was not the original specified behavoir:
#289 (comment)

[mit-mit]

[jonasfj]

I confirmed with @mit-mit that this also means removal from package listings. So you can only find the package if you go to the package URL... and you know the package name.

[isoos]

It looks like that the search index part of the isDiscontinued flag handling works, but there is no actual update of the index after the flag changes. There is a trigger, which works, the TaskScheduler picks it up, I can see traces of the PackageDocument creation, but the actual document does not reach the index.

[isoos]

I've debugged the related code with great details, and my current understanding is the following:

• Setting a package discontinued works as expected, with a small caveat: the bin/tools/flag.dart tool triggers an update only for the current (source-code) runtimeVersion, and if that differs from the deployed one, the update may happen later.

• The need to update the index's PackageDocument is picked up, the loading process recognizes it as discontinued, does not load it, marks it to-be-removed, and removes it from both the index and the snapshot.

Prod is now working as expected (at least for docgen). I've observed the issue on staging yesterday, the index was indeed not updated, but something changed today, and now it is updated correctly.

It may be related to caching. I've seen a similar glitch in the search result pagination caching: a certain page index was cached way longer than the intended 10 minutes, and it produced a really confusing result, as the index was updated behind it.

[isoos]

This is now fixed at staging, and will be part of the next prod release.