Remove the redundant DatastoreHistoryTaskSource.afterDays field. (#1000)

Author: isoos

app/lib/analyzer/task_sources.dart

@@ -11,6 +11,7 @@ import '../shared/task_scheduler.dart';
 import '../shared/task_sources.dart';
 import '../shared/versions.dart';
 
+import 'backend.dart' show reanalyzeThreshold;
 import 'models.dart';
 
 /// Creates a task when a version uploaded in the past 10 minutes has no
@@ -32,13 +33,14 @@ class AnalyzerDatastoreHeadTaskSource extends DatastoreHeadTaskSource {
   }
 }
 
-/// Creates a task when the most recent analysis is older than 30 days.
+/// Creates a task when the most recent analysis is older than
+/// [reanalyzeThreshold] days.
 class AnalyzerDatastoreHistoryTaskSource extends DatastoreHistoryTaskSource {
   final DatastoreDB _db;
 
   AnalyzerDatastoreHistoryTaskSource(DatastoreDB db)
       : _db = db,
-        super(db, afterDays: 30);
+        super(db);
 
   @override
   Future<bool> requiresUpdate(String packageName, String packageVersion,
@@ -58,7 +60,7 @@ class AnalyzerDatastoreHistoryTaskSource extends DatastoreHistoryTaskSource {
 
     final Duration diff =
         new DateTime.now().toUtc().difference(version.analysisTimestamp);
-    if (diff.inDays >= afterDays) return true;
+    if (diff >= reanalyzeThreshold) return true;
 
     if (retryFailed &&
         version.analysisStatus != AnalysisStatus.success &&

app/lib/dartdoc/backend.dart

@@ -17,7 +17,7 @@ import 'models.dart';
 
 final Logger _logger = new Logger('pub.dartdoc.backend');
 
-final Duration _entryUpdateThreshold = const Duration(days: 30);
+final Duration entryUpdateThreshold = const Duration(days: 90);
 final Duration _contentDeleteThreshold = const Duration(days: 1);
 
 /// Sets the dartdoc backend.
@@ -95,7 +95,7 @@ class DartdocBackend {
       return true;
     }
     final age = new DateTime.now().difference(entry.timestamp).abs();
-    if (age > _entryUpdateThreshold) {
+    if (age > entryUpdateThreshold) {
       return true;
     }
     return false;

app/lib/dartdoc/task_sources.dart

@@ -25,9 +25,10 @@ class DartdocDatastoreHeadTaskSource extends DatastoreHeadTaskSource {
   }
 }
 
-/// Creates a task when the most recent dartdoc run is older than 30 days.
+/// Creates a task when the most recent dartdoc run is older than
+/// [entryUpdateThreshold] days.
 class DartdocDatastoreHistoryTaskSource extends DatastoreHistoryTaskSource {
-  DartdocDatastoreHistoryTaskSource(DatastoreDB db) : super(db, afterDays: 30);
+  DartdocDatastoreHistoryTaskSource(DatastoreDB db) : super(db);
 
   @override
   Future<bool> requiresUpdate(String packageName, String packageVersion,
@@ -42,7 +43,7 @@ class DartdocDatastoreHistoryTaskSource extends DatastoreHistoryTaskSource {
 
     final now = new DateTime.now().toUtc();
     final age = now.difference(entry.timestamp).abs();
-    if (age.inDays >= afterDays) {
+    if (age >= entryUpdateThreshold) {
       return true;
     }
 

app/lib/shared/task_sources.dart

@@ -102,15 +102,11 @@ class DatastoreHeadTaskSource implements TaskSource {
       new Task(a.packageName, a.packageVersion, a.timestamp);
 }
 
-/// Creates a task when the most recent output is older than [afterDays] days.
+/// Creates a task when the most recent output requires an update (e.g. too old).
 abstract class DatastoreHistoryTaskSource implements TaskSource {
   final DatastoreDB _db;
-  final int afterDays;
 
-  DatastoreHistoryTaskSource(
-    this._db, {
-    this.afterDays: 30,
-  });
+  DatastoreHistoryTaskSource(this._db);
 
   Future<bool> requiresUpdate(String packageName, String packageVersion,
       {bool retryFailed: false});