Upgrade pub_dartdoc

Author: isoos

app/lib/shared/versions.dart

@@ -17,7 +17,7 @@ final RegExp runtimeVersionPattern = RegExp(r'\d{4}\.\d{2}\.\d{2}');
 /// Increment the version when a change is significant enough to trigger
 /// reprocessing, including: version change in pana, dartdoc, or the SDKs,
 /// or when an feature or bugfix should be picked up by the analysis ASAP.
-const String runtimeVersion = '2020.01.02';
+const String runtimeVersion = '2020.01.10';
 final Version semanticRuntimeVersion = Version.parse(runtimeVersion);
 
 /// The version which marks the earliest version of the data which we'd like to
@@ -26,7 +26,7 @@ final Version semanticRuntimeVersion = Version.parse(runtimeVersion);
 ///
 /// Make sure that at least two versions are kept here as the next candidates
 /// when the version switch happens:
-/// - 2020.01.02
+/// - 2020.01.10
 /// - 2019.12.13
 /// - 2019.12.09
 final String gcBeforeRuntimeVersion = '2019.11.29';
@@ -46,7 +46,7 @@ final String flutterVersion = '1.12.13+hotfix.5';
 final Version semanticFlutterVersion = Version.parse(flutterVersion);
 
 // keep in-sync with pkg/pub_dartdoc/pubspec.yaml
-final String dartdocVersion = '0.29.3';
+final String dartdocVersion = '0.30.0+1';
 final Version semanticDartdocVersion = Version.parse(dartdocVersion);
 
 // Version that control the dartdoc serving.

app/test/shared/versions_test.dart

@@ -31,7 +31,7 @@ void main() {
     // This test is a reminder that if pana, the SDK or any of the above
     // versions change, we should also adjust the [runtimeVersion]. Before
     // updating the hash value, double-check if it is being updated.
-    expect(hash, 446452479);
+    expect(hash, 425660634);
   });
 
   test('runtime version should be (somewhat) lexicographically ordered', () {

pkg/pub_dartdoc/lib/pub_data_generator.dart

@@ -7,6 +7,8 @@ import 'dart:convert' as convert;
 import 'dart:io';
 
 import 'package:dartdoc/dartdoc.dart';
+// ignore: implementation_imports
+import 'package:dartdoc/src/warnings.dart';
 import 'package:path/path.dart' as p;
 
 import 'package:pub_dartdoc_data/pub_dartdoc_data.dart';
@@ -17,7 +19,7 @@ const fileName = 'pub-data.json';
 /// [PubDartdocData] instance.
 class PubDataGenerator implements Generator {
   final _onFileCreated = StreamController<File>();
-  final _writtenFiles = Set<String>();
+  final _writtenFiles = <String, Warnable>{};
   final String _inputDirectory;
 
   PubDataGenerator(this._inputDirectory);
@@ -57,7 +59,10 @@ class PubDataGenerator implements Generator {
                 // the filename every time.
                 // source: p.relative(elem.sourceFileName, from: _inputDirectory),
                 source: null,
-                href: isReferenced ? _trimToNull(elem.href) : null,
+                href: isReferenced
+                    ? _trimToNull(elem.href
+                        ?.replaceAll('%%__HTMLBASE_dartdoc_internal__%%', ''))
+                    : null,
                 documentation: _trimToNull(elem.documentation),
               ));
       if (elem.enclosingElement is ModelElement) {
@@ -92,14 +97,14 @@ class PubDataGenerator implements Generator {
     final outputFile = File(p.join(outputDirectoryPath, fileName));
     await outputFile.writeAsString(convert.json.encode(extract.toJson()));
     _onFileCreated.add(outputFile);
-    _writtenFiles.add(fileName);
+    _writtenFiles[fileName] = null;
   }
 
   @override
   Stream<File> get onFileCreated => _onFileCreated.stream;
 
   @override
-  Set<String> get writtenFiles => _writtenFiles;
+  Map<String, Warnable> get writtenFiles => _writtenFiles;
 
   // Inherited member, should not show up in pub-data.json
   @override

pkg/pub_dartdoc/pubspec.lock

@@ -7,14 +7,14 @@ packages:
       name: _fe_analyzer_shared
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "1.0.1"
+    version: "1.0.3"
   analyzer:
     dependency: transitive
     description:
       name: analyzer
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.39.2+1"
+    version: "0.39.4"
   args:
     dependency: transitive
     description:
@@ -84,7 +84,7 @@ packages:
       name: dartdoc
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "0.29.3"
+    version: "0.30.0+1"
   file:
     dependency: transitive
     description:

pkg/pub_dartdoc/pubspec.yaml

@@ -8,7 +8,7 @@ dependencies:
   pub_dartdoc_data:
     path: ../pub_dartdoc_data
   # dartdoc version to be pinned, keep in-sync with app/lib/shared/versions.dart
-  dartdoc: 0.29.3
+  dartdoc: 0.30.0+1
 
 dev_dependencies:
   test: '^1.3.0'