Skip to content

Commit 2c82cd2

Browse files
authored
Dissolve package:messages_deserializer for pub publish (#751)
1 parent f02f748 commit 2c82cd2

31 files changed

+16
-151
lines changed

.github/labeler.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
'package:messages_serializer':
1919
- 'pkgs/messages_serializer/**'
2020

21-
'package:messages_deserializer':
22-
- 'pkgs/messages_deserializer/**'
23-
2421
'package:messages_builder':
2522
- 'pkgs/messages_builder/**'
2623

.github/workflows/messages_deserializer.yml

Lines changed: 0 additions & 41 deletions
This file was deleted.

pkgs/messages/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ To enable localization which supports
2626
The package is partitioned to allow a package to consume some parts of the library only as a `dev_dependency`, not including the message building and serialization packages in the dependencies for the application.
2727

2828
### `messages`
29-
Contains the interface for a `MessageList` and the different subtypes of `Message`s. Has a dependency on `messages_deserializer` to parse a data file into a `MessageList`.
30-
### `messages_deserializer`
31-
The logic for deserializing the data files into `MessageList`s.
29+
Contains the interface for a `MessageList` and the different subtypes of `Message`s as well as the functionality to parse a data file into a `MessageList`.
3230
### `messages_builder`
3331
The `builder` to generate the named methods and data files from the input `arb` translation files. Has a dependency on `messages_serializer` and `messages`.
3432

pkgs/messages/example_json/pubspec_overrides.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,3 @@ dependency_overrides:
33
path: ../
44
messages_serializer:
55
path: ../../messages_serializer
6-
messages_deserializer:
7-
path: ../../messages_deserializer

pkgs/messages/lib/messages.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
export 'src/deserializer/deserializer.dart';
56
export 'src/intl_object.dart' show IntlObject;
67
export 'src/intl_style_lookup.dart' show Intl;
78
export 'src/message_format.dart';

pkgs/messages/lib/messages_json.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@
33
// BSD-style license that can be found in the LICENSE file.
44

55
export 'messages.dart';
6+
export 'src/deserializer/deserializer_json.dart';
67
export 'src/message_list_json.dart';

pkgs/messages_deserializer/lib/src/deserializer.dart renamed to pkgs/messages/lib/src/deserializer/deserializer.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5-
import 'package:messages/messages.dart';
5+
import '../intl_object.dart';
6+
import '../message_format.dart';
67

78
abstract class Deserializer<T extends MessageList> {
89
T deserialize(IntlObject intl);

pkgs/messages_deserializer/lib/src/deserializer_json.dart renamed to pkgs/messages/lib/src/deserializer/deserializer_json.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44

55
import 'dart:convert';
66

7-
import 'package:messages/messages_json.dart';
8-
7+
import '../intl_object.dart';
8+
import '../message_format.dart';
9+
import '../message_list_json.dart';
910
import 'deserializer.dart';
1011

1112
class JsonDeserializer extends Deserializer<MessageListJson> {

pkgs/messages/lib/src/intl_object.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ abstract class IntlObject {
88
const IntlObject();
99

1010
Message gender(
11-
Gender gender,
11+
GenderEnum gender,
1212
Message? female,
1313
Message? male,
1414
Message other,

pkgs/messages/lib/src/message.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ final class GenderMessage extends Message {
106106
}) {
107107
return intl
108108
.gender(
109-
allArgs[argIndex] as Gender,
109+
allArgs[argIndex] as GenderEnum,
110110
female,
111111
male,
112112
other,
@@ -120,7 +120,7 @@ final class GenderMessage extends Message {
120120
}
121121
}
122122

123-
enum Gender {
123+
enum GenderEnum {
124124
female,
125125
male,
126126
other;

0 commit comments

Comments
 (0)