Skip to content

Commit c9d0414

Browse files
authored
update the trebuchet remaining steps output into a markdown list (#300)
- update the trebuchet remaining steps output into a markdown list; this could then be added to a PR in order to track the remaining transfer work --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
1 parent 492a5bd commit c9d0414

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

.github/labeler.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,7 @@
2727
'package:sdk_triage_bot':
2828
- changed-files:
2929
- any-glob-to-any-file: 'pkgs/sdk_triage_bot/**/*'
30+
31+
'package:trebuchet':
32+
- changed-files:
33+
- any-glob-to-any-file: 'pkgs/trebuchet/**/*'

pkgs/trebuchet/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ dart run bin/trebuchet.dart \
99
--input-name coverage \
1010
--branch-name main \
1111
--input-path ~/projects/coverage/ \
12-
--target labs \
12+
--target tools \
1313
--target-path ~/projects/tools/ \
1414
--git-filter-repo ~/tools/git-filter-repo \
1515
--dry-run
1616
```
1717

18-
This basically executes the instructions at https://github.com/dart-lang/ecosystem/wiki/Merging-existing-repos-into-a-monorepo
18+
This script automates portions of the instructions at
19+
https://github.com/dart-lang/ecosystem/wiki/Merging-existing-repos-into-a-monorepo.

pkgs/trebuchet/bin/trebuchet.dart

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -165,23 +165,23 @@ class Trebuchet {
165165
}
166166

167167
final remainingSteps = [
168-
'Move and fix workflow files',
168+
'move and fix workflow files',
169169
if (!shouldPush)
170-
'Run `git push --set-upstream origin merge-$input-package` in the monorepo directory',
171-
'Disable squash-only in GitHub settings, and merge with a fast forward merge to the main branch, enable squash-only in GitHub settings.',
172-
"Push tags to github using `git tag --list '$input*' | xargs git push origin`",
173-
'Follow up with a PR adding links to the top-level readme table.',
174-
'Transfer issues by running `dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/$input --target-repo dart-lang/$target --add-label package:$input --apply-changes`',
175-
"Add a commit to https://github.com/dart-lang/$input/ with it's readme pointing to the monorepo.",
176-
'Update the auto-publishing settings on pub.dev/packages/$input.',
177-
'Archive https://github.com/dart-lang/$input/.',
170+
'run `git push --set-upstream origin merge-$input-package` in the monorepo directory',
171+
"enable 'Allow merge commits' in GitHub settings; merge the PR with 'Create a merge commit'; disable 'Allow merge commits'",
172+
"push tags to GitHub using `git tag --list '$input*' | xargs git push origin`",
173+
'follow up with a PR adding links to the top-level readme table',
174+
'transfer issues by running `dart run pkgs/repo_manage/bin/report.dart transfer-issues --source-repo dart-lang/$input --target-repo dart-lang/$target --add-label package:$input --apply-changes`',
175+
'update the auto-publishing settings on pub.dev/packages/$input',
176+
"add a commit to https://github.com/dart-lang/$input/ with it's readme pointing to the monorepo",
177+
'archive https://github.com/dart-lang/$input/',
178178
];
179179

180180
print('DONE!');
181181
print('''
182182
Steps left to do:
183183
184-
${remainingSteps.map((step) => ' - $step').join('\n')}
184+
${remainingSteps.map((step) => '- [ ] $step').join('\n')}
185185
''');
186186
}
187187

0 commit comments

Comments
 (0)