Skip to content

Commit 70521d7

Browse files
authored
Update health.dart (#298)
See dart-lang/tools#587 (comment) --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
1 parent 4ba6f15 commit 70521d7

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed

pkgs/corpus/lib/api.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,8 @@ class ApiUseCollector extends RecursiveAstVisitor implements SurveyorVisitor {
180180
return;
181181
}
182182

183+
//TODO: fix as soon as enclosingElement3 is on Dart stable
184+
// ignore: deprecated_member_use
183185
var enclosingElement = element.enclosingElement!;
184186

185187
if (enclosingElement.kind == ElementKind.CLASS) {

pkgs/firehose/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.9.3
2+
3+
- Do not check Dart SDK in PR Health breaking check.
4+
15
## 0.9.2
26

37
- Improve formatting of the github workflow summary comments so they use less

pkgs/firehose/lib/src/health/health.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automati
166166
...['pub', 'global', 'run'],
167167
'dart_apitool:main',
168168
'diff',
169+
'--no-check-sdk-version',
169170
...['--old', baseRelativePath],
170171
...['--new', relativePath],
171172
...['--report-format', 'json'],

pkgs/firehose/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: firehose
22
description: A tool to automate publishing of Pub packages from GitHub actions.
3-
version: 0.9.2
3+
version: 0.9.3
44
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
55

66
environment:

0 commit comments

Comments
 (0)