Only check text files for "do not submit" string (#243)

* Only check text files for do not submit string

* Rev version

Author: mosuem

pkgs/firehose/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.8.0
+
+- Only check text files for do not submit strings.
+
 ## 0.7.0
 
 - Add `ignore-packages` flag to the publish workflow.

pkgs/firehose/lib/src/health/health.dart

@@ -306,13 +306,17 @@ Changes to files need to be [accounted for](https://github.com/dart-lang/ecosyst
 
   Future<HealthCheckResult> doNotSubmitCheck() async {
     final dns = 'DO_NOT${'_'}SUBMIT';
+    // To avoid trying to read non-text files.
+    const supportedExtensions = ['.dart', '.json', '.md', '.txt'];
 
     final body = await github.pullrequestBody();
     final files = await github.listFilesForPR(directory, ignoredPackages);
     print('Checking for DO_NOT${'_'}SUBMIT strings: $files');
     final filesWithDNS = files
         .where((file) =>
             ![FileStatus.removed, FileStatus.unchanged].contains(file.status))
+        .where((file) =>
+            supportedExtensions.contains(path.extension(file.filename)))
         .where((file) => File(file.pathInRepository)
             .readAsStringSync()
             .contains('DO_NOT${'_'}SUBMIT'))

pkgs/firehose/pubspec.yaml

@@ -1,6 +1,6 @@
 name: firehose
 description: A tool to automate publishing of Pub packages from GitHub actions.
-version: 0.7.0
+version: 0.8.0
 repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose
 
 environment:

pkgs/firehose/test/health_test.dart

@@ -25,6 +25,11 @@ Future<void> main() async {
       FileStatus.added,
       directory,
     ),
+    GitFile(
+      'pkgs/package2/someImage.png',
+      FileStatus.added,
+      directory,
+    ),
   ]);
   await Process.run('dart', ['pub', 'global', 'activate', 'dart_apitool']);
   await Process.run('dart', ['pub', 'global', 'activate', 'coverage']);