Skip to content

Commit 2719d0c

Browse files
authored
add invalid_runtime_check_with_js_interop_types, unintended_html_in_doc_comment (#285)
- add `invalid_runtime_check_with_js_interop_types` - add `unintended_html_in_doc_comment` - prep for publishing The idea behind this revision is to use the above two lints for a period of time ourselves (these lints are likely going out with the next major revision of `package:lints` - see https://github.com/orgs/dart-lang/projects/73). --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. <details> <summary>Contribution guidelines:</summary><br> - See our [contributor guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md) for general expectations for PRs. - Larger or significant changes should be discussed in an issue before creating a PR. - Contributions to our repos should follow the [Dart style guide](https://dart.dev/guides/language/effective-dart) and use `dart format`. - Most changes should add an entry to the changelog and may need to [rev the pubspec package version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change). - Changes to packages require [corresponding tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing). Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback. </details>
1 parent f977423 commit 2719d0c

File tree

5 files changed

+88
-50
lines changed

5 files changed

+88
-50
lines changed

.github/workflows/dart.yml

Lines changed: 78 additions & 45 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkgs/dart_flutter_team_lints/CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
1-
## 3.1.1-wip
1+
## 3.2.0
22

3-
- Contribute a (brief) change policy to the readme.
3+
- Contributed a (brief) change policy to the readme.
4+
- Added `invalid_runtime_check_with_js_interop_types`.
5+
- Added `unintended_html_in_doc_comment`.
6+
- Require Dart `3.5`.
47

58
## 3.1.0
69

pkgs/dart_flutter_team_lints/lib/analysis_options.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,11 @@ linter:
4545
- avoid_dynamic_calls
4646
- comment_references
4747
- conditional_uri_does_not_exist
48+
- invalid_runtime_check_with_js_interop_types
4849
- only_throw_errors
4950
- test_types_in_equals
5051
- throw_in_finally
5152
- type_annotate_public_apis
5253
- unawaited_futures
54+
- unintended_html_in_doc_comment
5355
- unreachable_from_main

pkgs/dart_flutter_team_lints/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
name: dart_flutter_team_lints
22
description: An analysis rule set used by the Dart and Flutter teams.
3-
version: 3.1.1-wip
3+
version: 3.2.0
44
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints
55

66
environment:
7-
sdk: ^3.4.0
7+
sdk: ^3.5.0
88

99
dependencies:
1010
lints: ^4.0.0

tool/ci.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# Created with package:mono_repo v6.6.1
2+
# Created with package:mono_repo v6.6.2
33

44
# Support built in commands on windows out of the box.
55

0 commit comments

Comments
 (0)