Refactor snapshot cache initialization to better support nnbd #2761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Aug 23, 2021
| /// function must be called before process exit to clean up snapshots in the | ||
| /// cache. | ||
| class SnapshotCache { | ||
| static SnapshotCache _instance; | ||
| static final _instances = <ResourceProvider, SnapshotCache>{}; |
There was a problem hiding this comment.
Gnerally exactly one key/value pair in any given execution, yeah? Maybe like... two, for a test execution that uses mocks and real test packages.
There was a problem hiding this comment.
Yes. The cache pretended before that there was only ever one, but I was suspicious of how it handled mocks or other inputs by ignoring them after the first call to createInstance if you hadn't dispose()d of them. That seemed like a bad idea in an asynchronous program, and was a pain to migrate without a refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.