From e6694a9d26079e0336d08c156d2a2769ec0da9de Mon Sep 17 00:00:00 2001
From: Janice Collins <jcollins@google.com>
Date: Thu, 16 Jan 2020 14:57:53 -0800
Subject: [PATCH] Enforce the unused import lint on presubmit via analysis
 warnings

---
 analysis_options.yaml           | 3 +++
 bin/dartdoc.dart                | 1 -
 lib/src/empty_generator.dart    | 1 -
 lib/src/generator.dart          | 2 +-
 lib/src/generator_frontend.dart | 2 --
 test/src/utils.dart             | 1 -
 6 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/analysis_options.yaml b/analysis_options.yaml
index 5bbf4f3e53..d8b63b301d 100644
--- a/analysis_options.yaml
+++ b/analysis_options.yaml
@@ -1,6 +1,9 @@
 include: package:pedantic/analysis_options.1.8.0.yaml
 
 analyzer:
+  errors:
+    unused_import: warning
+    unused_shown_name: warning
   exclude:
     - 'doc/**'
     - 'lib/src/third_party/pkg/**'
diff --git a/bin/dartdoc.dart b/bin/dartdoc.dart
index bd6bad48c5..f76c82549a 100644
--- a/bin/dartdoc.dart
+++ b/bin/dartdoc.dart
@@ -9,7 +9,6 @@ import 'dart:io';
 
 import 'package:args/args.dart';
 import 'package:dartdoc/dartdoc.dart';
-import 'package:dartdoc/src/html/html_generator.dart';
 import 'package:dartdoc/src/logging.dart';
 import 'package:dartdoc/src/tool_runner.dart';
 import 'package:stack_trace/stack_trace.dart';
diff --git a/lib/src/empty_generator.dart b/lib/src/empty_generator.dart
index 595a666ba3..4e4ad8e524 100644
--- a/lib/src/empty_generator.dart
+++ b/lib/src/empty_generator.dart
@@ -7,7 +7,6 @@ import 'package:dartdoc/src/generator.dart';
 import 'package:dartdoc/src/logging.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/model_utils.dart';
-import 'package:dartdoc/src/warnings.dart';
 
 /// A generator that does not generate files, but does traverse the [PackageGraph]
 /// and access [ModelElement.documentationAsHtml] for every element as though
diff --git a/lib/src/generator.dart b/lib/src/generator.dart
index 28a0e8eb35..f705f53e7d 100644
--- a/lib/src/generator.dart
+++ b/lib/src/generator.dart
@@ -5,7 +5,7 @@
 /// A library containing an abstract documentation generator.
 library dartdoc.generator;
 
-import 'dart:async' show Stream, Future;
+import 'dart:async' show Future;
 import 'dart:io' show Directory;
 import 'dart:isolate';
 
diff --git a/lib/src/generator_frontend.dart b/lib/src/generator_frontend.dart
index ff65f1e172..5b62800322 100644
--- a/lib/src/generator_frontend.dart
+++ b/lib/src/generator_frontend.dart
@@ -3,14 +3,12 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:io' show File;
 
 import 'package:dartdoc/src/generator.dart';
 import 'package:dartdoc/src/logging.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/model_utils.dart';
 import 'package:dartdoc/src/warnings.dart';
-import 'package:path/path.dart' as path;
 
 /// [Generator] that delegates rendering to a [GeneratorBackend] and delegates
 /// file creation to a [FileWriter].
diff --git a/test/src/utils.dart b/test/src/utils.dart
index b5d8a793df..8fbdf9f4d5 100644
--- a/test/src/utils.dart
+++ b/test/src/utils.dart
@@ -10,7 +10,6 @@ import 'dart:io';
 
 import 'package:async/async.dart';
 import 'package:dartdoc/dartdoc.dart';
-import 'package:dartdoc/src/html/html_generator.dart';
 import 'package:dartdoc/src/model/model.dart';
 import 'package:dartdoc/src/package_meta.dart';
 import 'package:path/path.dart' as path;