From 2b4330e98af13a96491353d8006aee48c456543c Mon Sep 17 00:00:00 2001 From: Janice Collins Date: Mon, 22 May 2017 12:55:01 -0700 Subject: [PATCH 1/4] Update README with triage priorities --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e5e72efe1f..556475f5a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,7 @@ +## 0.12.0 +* Miscellaneous performance enhancements, ~10-20% on complex packages. * Enable support for generic function types. #1321 -* Update analyzer to 0.30. #1403 +* Update analyzer to 0.30. Minimum Dart SDK 1.23 now required. #1403 * Enhancements to css style to better match dartlang.org. #1372 (partial) ## 0.11.2 From afda63da08a1bc956174765bfe1d4f9ecc3eb38d Mon Sep 17 00:00:00 2001 From: Janice Collins Date: Mon, 22 May 2017 12:59:43 -0700 Subject: [PATCH 2/4] actually add the readme --- README.md | 40 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 218f293ee5..2968a42743 100644 --- a/README.md +++ b/README.md @@ -121,7 +121,45 @@ all the used libraries, even from other packages, to the list of the documented ## Issues and bugs -Please file reports on the [GitHub Issue Tracker][]. +Please file reports on the [GitHub Issue Tracker][]. Issues are labeled with +priority based on how much impact to the ecosystem the issue addresses and +the number of generated pages that show the anomaly (widespread vs. not +widespread). + +Some examples of likely triage priorities: + +* P0 + * Broken links, widespread + * Uncaught exceptions, widespread + * Incorrect linkage, widespread + * Very ugly or navigation impaired generated pages, widespread + +* P1 + * Broken links, few or on edge cases + * Uncaught exceptions, very rare or with simple workarounds + * Incorrect linkage, few or on edge cases + * Incorrect doc contents, widespread or with high impact + * Minor display warts not significantly impeding navigation, widespread + * Default-on warnings that are misleading or wrong, widespread + * Generation problems that should be detected but aren't warned, widespread + * Enhancements that have significant data around them indicating they are a big win + +* P2 + * Incorrect doc contents, not widespread + * Minor display warts not significantly impeding navigation, not widespread + * Generation problems that should be detected but aren't warned, not widespread + * Default-on warnings that are misleading or wrong, few or on edge cases + * Non-default warnings that are misleading or wrong, widespread + * Enhancements considered important but without significant data indicating they are a big win + * Performance problem, widespread + +* P3 + * Theoretical or extremely rare problems with generation + * Minor display warts on edge cases only + * Non-default warnings that are misleading or wrong, few or on edge cases + * Enhancements whose importance is uncertain + * Performance problem, limited impact or not widespread + ## License From 92b60b70642213afe42ebbde3cc482d76bc711df Mon Sep 17 00:00:00 2001 From: Janice Collins Date: Mon, 22 May 2017 12:59:57 -0700 Subject: [PATCH 3/4] revert changelog change, oops. --- CHANGELOG.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 556475f5a2..e5e72efe1f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,5 @@ -## 0.12.0 -* Miscellaneous performance enhancements, ~10-20% on complex packages. * Enable support for generic function types. #1321 -* Update analyzer to 0.30. Minimum Dart SDK 1.23 now required. #1403 +* Update analyzer to 0.30. #1403 * Enhancements to css style to better match dartlang.org. #1372 (partial) ## 0.11.2 From ca244cb0cfe7d6e9b3fa80585b2b63835f2101ea Mon Sep 17 00:00:00 2001 From: Janice Collins Date: Mon, 22 May 2017 14:23:40 -0700 Subject: [PATCH 4/4] User performance problem added to triage guide per Hixie --- README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 2968a42743..b215697a7a 100644 --- a/README.md +++ b/README.md @@ -143,6 +143,7 @@ Some examples of likely triage priorities: * Default-on warnings that are misleading or wrong, widespread * Generation problems that should be detected but aren't warned, widespread * Enhancements that have significant data around them indicating they are a big win + * User performance problem (e.g. page load, search), widespread * P2 * Incorrect doc contents, not widespread @@ -151,14 +152,15 @@ Some examples of likely triage priorities: * Default-on warnings that are misleading or wrong, few or on edge cases * Non-default warnings that are misleading or wrong, widespread * Enhancements considered important but without significant data indicating they are a big win - * Performance problem, widespread + * User performance problem (e.g. page load, search), not widespread + * Generation performance problem, widespread * P3 * Theoretical or extremely rare problems with generation * Minor display warts on edge cases only * Non-default warnings that are misleading or wrong, few or on edge cases * Enhancements whose importance is uncertain - * Performance problem, limited impact or not widespread + * Generation performance problem, limited impact or not widespread ## License