Skip to content

Instruct analyzer to ignore all HTML #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sethladd opened this issue Aug 3, 2015 · 4 comments · Fixed by #770
Closed

Instruct analyzer to ignore all HTML #760

sethladd opened this issue Aug 3, 2015 · 4 comments · Fixed by #770
Labels
type-enhancement A request for a change that isn't a bug
Milestone
0.4.0

Comments

@sethladd
Copy link
Contributor

sethladd commented Aug 3, 2015

I don't believe we have any requirement for the analyzer to try to analyze the HTML in our project. I assume this speeds things up, if we ignore *.html
@sethladd sethladd added the type-enhancement A request for a change that isn't a bug label Aug 3, 2015
@sethladd sethladd added this to the Branch milestone Aug 3, 2015
@sethladd
Copy link
Contributor Author

sethladd commented Aug 5, 2015

@devoncarew is this easy for you to do?

@devoncarew
Copy link
Member

I think this is taken care of by this file:

https://github.com/dart-lang/dartdoc/blob/master/.analysis_options#L6

@johnmccutchan committed a change will will make sure that our top-level pubspec file can affect exclusions in all sub-dirs. If you're seeing html files being analyzed in the dartdoc project, you're probably running into that. The fix will be in the next dev sdk.

Re: having the analyzer ignore generated docs in general, that seems like a good idea. It already ignores build/ explicitly. Adding doc/api/ would make sense as well.

@sethladd
Copy link
Contributor Author

sethladd commented Aug 5, 2015

Can we also ignore lib/templates ?

@devoncarew devoncarew mentioned this issue Aug 5, 2015
Merged
@sethladd
Copy link
Contributor Author

sethladd commented Aug 5, 2015

👍

@sethladd sethladd modified the milestones: Branch, 0.4.0 Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

ignore html template files dart-lang/dartdoc
2 participants
@sethladd @devoncarew