Skip to content

Slow to document package:fhir? #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isoos opened this issue Nov 19, 2020 · 9 comments
Closed

Slow to document package:fhir? #2436

isoos opened this issue Nov 19, 2020 · 9 comments
Labels
P2 A bug or feature request we're likely to work on type-performance Issues related to slow dartdoc generation.

Comments

@isoos
Copy link
Contributor

isoos commented Nov 19, 2020

Original report: dart-lang/pub-dev#4261

To replicate:

  • Download and extract fhir 0.0.11 from here.
  • go to the extracted directory
  • pub get
  • pub global run dartdoc --json .

There seems to be no update about the progress, but the CPU is fully saturated for 20+ minutes on my MacBook.

@isoos
Copy link
Contributor Author

isoos commented Nov 19, 2020

Note: the package archive is larger than usual, maybe it is some operation related to that?

@jcollins-g jcollins-g added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Nov 19, 2020
@jcollins-g
Copy link
Contributor

It was slow, but completed on my machine. 223.5 seconds to initialize, and 245.9 seconds to document. Since this is pretty unusual I will set priority to P2 and see if there is a specific reason (other than this package being fairly large, 182 public libraries).

@srawlins
Copy link
Member

Pretty long!

Definitely one to keep an eye on when doing performance improvements; for example mustache changes :D

@jcollins-g
Copy link
Contributor

@srawlins I was thinking the same thing :-)

@jcollins-g
Copy link
Contributor

For perspective, the Flutter SDK, current leader for single biggest documentation job in the Dart ecosystem, initializes on the same machine in 154.3 seconds and documents in 445.4 seconds.

@jcollins-g
Copy link
Contributor

The performance improvements in 0.38 helps things a little bit, but not as much as I expected. This may be because this package contains an extremely complex import-export graph and lots of shallow classes, which reduces the benefit of not rerendering sidebars.

@isoos
Copy link
Contributor Author

isoos commented Apr 14, 2021

Added #2615 for more debug information on slow packages.

@srawlins srawlins changed the title Possible infinite loop while running on package:fhir? Slow to document package:fhir? Mar 25, 2022
@srawlins srawlins added the type-performance Issues related to slow dartdoc generation. label Mar 25, 2022
@sigurdm
Copy link
Contributor

sigurdm commented Apr 8, 2025

Seems like dartdoc now completes the recent version of package:fhir
(but dart format times out??) https://pub.dev/packages/fhir/score/log.txt

@isoos
Copy link
Contributor Author

isoos commented Apr 8, 2025

Closing as obsolete.

@isoos isoos closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-performance Issues related to slow dartdoc generation.
Projects
None yet
Development

No branches or pull requests

4 participants