Skip to content

Use a file system abstraction #2297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Aug 14, 2020 · 0 comments · Fixed by #2315
Closed

Use a file system abstraction #2297

srawlins opened this issue Aug 14, 2020 · 0 comments · Fixed by #2315
Labels
P2 A bug or feature request we're likely to work on type-tech-debt Issues that slow or block desirable development paths for Dartdoc, or create such problems for users

Comments

@srawlins
Copy link
Member

This is required for making the integration tests smaller, and will encourage better testing. Currently, the dartdoc repository exclusively uses real file system APIs like Directory() from dart:io. It should instead use an abstraction, like package:file, or ResourceProvider from analyzer. I vote ResourceProvider. Then PhysicalResourceProvider is used in real code, and MemoryResourceProvider is used in tests.
@srawlins srawlins added P2 A bug or feature request we're likely to work on type-tech-debt Issues that slow or block desirable development paths for Dartdoc, or create such problems for users labels Aug 14, 2020
@srawlins srawlins mentioned this issue Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 A bug or feature request we're likely to work on type-tech-debt Issues that slow or block desirable development paths for Dartdoc, or create such problems for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update all (approximately) i/o operations to use ResourceProvider srawlins/dartdoc
1 participant
@srawlins