Skip to content

dartdoc exception on 2.9.0-1.0.dev #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Apr 20, 2020 · 3 comments · Fixed by #2186
Closed

dartdoc exception on 2.9.0-1.0.dev #2185

jcollins-g opened this issue Apr 20, 2020 · 3 comments · Fixed by #2186
Labels
P0 A serious issue requiring immediate resolution

Comments

@jcollins-g
Copy link
Contributor

The new format of the SDK version number causes the version parser in pub_semver 1.4.4 to return a different type for the preRelease.first version component.

dart2-dartdoc_test.dart: 05:15 +9 -2: dartdoc with generators basic interlinking test [E]
dart2-dartdoc_test.dart:
dart2-dartdoc_test.dart:   type 'int' is not a subtype of type 'String'
dart2-dartdoc_test.dart:
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package.dart 229:17                  Package.baseHref.<fn>
dart2-dartdoc_test.dart:   dart:core-patch/string_patch.dart 731:35                       _StringBase.replaceAllMapped
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package.dart 220:30                  Package.baseHref
dart2-dartdoc_test.dart:   package:dartdoc/src/model/class.dart 241:23                    Class.href
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package_graph.dart 572:37            PackageGraph._addToImplementors._checkAndAddClass
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package_graph.dart 586:24            PackageGraph._addToImplementors
dart2-dartdoc_test.dart:   dart:core-patch/array.dart 113:8                               List.forEach
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package_graph.dart 82:28             PackageGraph.initializePackageGraph.<fn>.<fn>
dart2-dartdoc_test.dart:   dart:core-patch/growable_array.dart 282:8                      List.forEach
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package_graph.dart 81:25             PackageGraph.initializePackageGraph.<fn>
dart2-dartdoc_test.dart:   dart:core-patch/growable_array.dart 282:8                      List.forEach
dart2-dartdoc_test.dart:   package:dartdoc/src/model/package_graph.dart 79:33             PackageGraph.initializePackageGraph
dart2-dartdoc_test.dart:   ===== asynchronous gap ===========================
@jcollins-g jcollins-g added the P0 A serious issue requiring immediate resolution label Apr 20, 2020
@jcollins-g
Copy link
Contributor Author

P0 as this will impact any use of --link-to-remote, which is an important use case for pub.

@jonasfj
Copy link
Member

jonasfj commented Apr 22, 2020

I'm not sure how it would affect pub.dev, we don't use pre-release versions of the dart-sdk (well, it happens, but we try to avoid it). Maybe, if the package has a lower bound SDK constraint on a pre-release?

In any case, we'll do our best to pick up the next release. Feel free to ping me when this ships.

@jcollins-g
Copy link
Contributor Author

@jonasf It shouldn't affect pub unless you try to run dartdoc with a dev release -- dartdoc tries to link against the SDK you're running with, rather than anything based on constraints.

Regardless, 0.31.0 has published with the patch, so updating to that should eliminate that worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants