Skip to content

Search bar hint and other text misaligned on Safari #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jcollins-g opened this issue Feb 5, 2019 · 0 comments
Closed

Search bar hint and other text misaligned on Safari #1926

jcollins-g opened this issue Feb 5, 2019 · 0 comments
Assignees
@jcollins-g
Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented Feb 5, 2019 •
edited
Loading

I think this may have gotten worse since 0.28.0. While things look fine on Firefox and Chrome, Safari's text inside the search box is aligned really far down, almost off the visible edge of the box so that only the tops of the letters can be seen.

This is related to flutter/flutter#22967 and I think a combination of a fix in dartdoc's base styles with one in flutter's overrides will correct both problems.
@jcollins-g jcollins-g added P2 A bug or feature request we're likely to work on customer-flutter Issues originating from important to Flutter labels Feb 5, 2019
@jcollins-g jcollins-g self-assigned this Feb 5, 2019
@jcollins-g jcollins-g mentioned this issue Feb 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcollins-g jcollins-g

Labels
customer-flutter Issues originating from important to Flutter P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcollins-g